JS: refactor UriLibraries.qll models to use DataFlow::moduleMember
#21
Conversation
| */ | ||
| DataFlow::SourceNode uridashjs() { | ||
| result = DataFlow::moduleImport("uri-js") | ||
| DataFlow::SourceNode uridashjsMember(string name) { |
There was a problem hiding this comment.
Can we make this predicate (and its brethren below) private?
There was a problem hiding this comment.
I can, but that will break all of the library-specific sanity tests.
|
LGTM. Did you check for any new results? |
No, the workers are too busy currently. I will try to do a local evaluation tonight. |
|
This PR adds no new results for our benchmark projects. |
|
This is a backwards-incompatible change since @esben-semmle, in future let's not expose predicates like these unless we absolutely have to. In this case, I think we could have avoided this by writing one set of tests for the whole library, which in turn would have avoided the backwards compatibility issues. |
JavaScript: Move LGTM suites to submodule.
|
Deprecation markers added. |
|
Thanks; could you squash the fixup, please? |
|
Done |
Extract 'this'-like value parameters
As discussed.
I do not think a change note is required for each library.