C++: add support for custom wide character sizes #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain Microsoft projects, such as CoreCLR and ChakraCore, use a library called the PAL, which enables two-byte strings in the printf family of functions, even when built on a platform with four-byte strings. This adds support for determining the size of a wide character from the definitions of such functions, rather than assuming that they match the compiler's wchar_t.
|
Semmle employees, please see the discussion at https://git.semmle.com/Semmle/public-ql/pull/49 |
|
I'd like to have Geoffrey review this if it can wait until next week when he's back from holiday. |
jonas-semmle
pushed a commit
that referenced
this pull request
Aug 7, 2018
JavaScript: Fix outdated qldoc in `DataFlow.qll`.
|
As far as I can tell my comments on https://git.semmle.com/Semmle/public-ql/pull/49 still need responding to. Also, I think this needs a change note. |
|
I'll close this. @geoffw0 has agreed to take over this branch and get it ready for merging. |
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Add Locations.qll and import FileSystem and Locations libraries in generated AST
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Remove leftover comment class
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Only generate `AsExpr`s when there is an `as` keyword
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Only generate `AsExpr`s when there is an `as` keyword
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
feat(queries): Migrate queries from AdvancedSecurity repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Microsoft projects, such as CoreCLR and ChakraCore, use a
library called the PAL, which enables two-byte strings in the printf
family of functions, even when built on a platform with four-byte
strings. This adds support for determining the size of a wide character
from the definitions of such functions, rather than assuming that they
match the compiler's wchar_t.