Skip to content

C++: Make Folder.getURL() consistent with Folder.getLocation() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

C++: Make Folder.getURL() consistent with Folder.getLocation() #3

merged 1 commit into from
Aug 21, 2018

Conversation

ian-semmle
Copy link
Contributor

This fixes confusing behaviour like:

from Element e, Folder f
where e = f
select e, f

file:///home/ian:0:0:0:0 | /home/ian | folder:///home/ian | /home/ian |

calumgrant pushed a commit to calumgrant/ql that referenced this pull request Aug 3, 2018
Merge pull request github#3 from pavel/integrate-master
5033507 
 JavaScript: Pull in changes up to 53548a6024b51
@jbj
Copy link
Contributor

jbj commented Aug 15, 2018

@ian-semmle This is blocked on our internal PR 27026, isn't it? If we make this change without agreeing on changing the spec first, then we're no longer following the spec.

jbj
jbj approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file system API spec now is updated to allow this change, so I'm happy to merge it.

@jbj jbj merged commit cb51a42 into github:master Aug 21, 2018
@ian-semmle ian-semmle deleted the getURL branch August 21, 2018 10:40
geoffw0 pushed a commit that referenced this pull request Jun 18, 2019
@denislevin
Merge pull request #3 from geoffw0/dates-fix
6a05c84 
CPP: Fixes for C++: Mishandling Japanese Era and Leap Year in calculations #1354
aschackmull pushed a commit that referenced this pull request Jan 31, 2020
@ggolawski
Merge pull request #3 from aschackmull/java/pr-2651-unittest
d065ebd 
Java: Add unit test for ldap injection.
garbervetsky pushed a commit to shuvendu-lahiri/ql that referenced this pull request Dec 15, 2020
@thepalbi
Run multiple steps at once (github#3)
881ba29 
* --steps flag to run multiple steps

* README updated
aibaars added a commit that referenced this pull request Oct 14, 2021
@aibaars
Merge pull request #3 from github/aibaars/codeql-extractor-yaml
305fd56 
Basic CodeQL extractor configuration and autobuild scripts
smowton referenced this pull request in smowton/codeql Oct 28, 2021
@igfoo
Merge pull request #3 from github/igfoo/supertypes
e44061a 
Kotlin: Add support for supertypes
geoffw0 pushed a commit that referenced this pull request May 31, 2022
@MathiasVP
Merge pull request #3 from geoffw0/swiftsrc
a175f49 
Swift: Add swift-security-and-quality, swift-security-extended packs.
tiferet added a commit that referenced this pull request Aug 3, 2022
@tiferet
ATM model for a DCA experiment
56d79c6 
Feature selection: Use a shipping model with the new features excluding fileImports and calleeImports. Model #3.

github/ml-ql-adaptive-threat-modeling#1968 (comment)
tiferet added a commit that referenced this pull request Sep 7, 2022
@tiferet
ATM model for a DCA experiment
9116817 
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #3

https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479795_acd730eb?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
tiferet added a commit that referenced this pull request Sep 16, 2022
@tiferet
ATM model for a DCA experiment
3d09153 
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #3 (with a fixed package version)

https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479795_acd730eb?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
tiferet added a commit that referenced this pull request Sep 19, 2022
@tiferet
ATM model for a DCA experiment
08ca55a 
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #3 (with a fixed package version)

https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479795_acd730eb?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
@pwntester pwntester mentioned this pull request Nov 16, 2022
Merged
jhelie pushed a commit that referenced this pull request Nov 22, 2022
@tiferet @jhelie
ATM model for a DCA experiment
abcc09c 
New features: Shipping model. 9 new features, remove the old ones that have been replaced by new ones. The codeql PR has been rebased on top of main. #3 (with a fixed package version)

https://ml.azure.com/experiments/id/85e6e910-7301-4441-9079-01a1e42fd45b/runs/classification_1662479795_acd730eb?wsid=/subscriptions/91095667-e119-4555-acea-1826488492f0/resourceGroups/atm-codeml/providers/Microsoft.MachineLearningServices/workspaces/ATM-workspace&tid=398a6654-997b-47e9-b12b-9515b896b4de
aschackmull added a commit that referenced this pull request Mar 6, 2023
@aschackmull
Merge pull request #3 from MathiasVP/fix-exec-tainted
d4c5877 
C++: Use refactored dataflow library in `cpp/command-line-injection`
MathiasVP pushed a commit that referenced this pull request May 9, 2023
@geoffw0
Merge pull request #3 from MathiasVP/add-puns-to-mad-2
268db8b 
Swift: Syntax for selecting `PostUpdateNode`s in CSV rows
@aschackmull aschackmull mentioned this pull request Sep 27, 2023
Merged
jketema pushed a commit that referenced this pull request Sep 5, 2024
@am0o0
Merge pull request #3 from jketema/amammad-cpp-bombs
a226bdf 
C++: Fix expected test results
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Merge pull request #3 from GitHubSecurityLab/extensible_predicates
f2fc411 
Add support for external definitions
@geoffw0 geoffw0 mentioned this pull request Mar 11, 2025
Merged
nicolaswill added a commit that referenced this pull request May 12, 2025
@nicolaswill
Merge pull request #3 from nicolaswill/nicolaswill/shared-crypto-library
7a96f56 
Move language-agnostic model to shared library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees

@jbj jbj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-semmle @jbj