Skip to content

CPP: Add query for CWE-297: Improper Validation of Certificate with Host Mismatch #9086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

CPP: Add query for CWE-297: Improper Validation of Certificate with Host Mismatch #9086

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ed755bd
create new branchihsinme-patch-101 in fork
May 9, 2022
4a58910
Update ValidationCertificateHostMismatch.expected
ihsinme Jun 2, 2022
39bd9e9
Create test1.cpp
ihsinme Jun 2, 2022
49d962e
Update ValidationCertificateHostMismatch.ql
ihsinme Jun 22, 2022
cec3555
Update test.cpp
ihsinme Jun 22, 2022
52ade48
Update test1.cpp
ihsinme Jun 22, 2022
8bf704f
Create test2.cpp
ihsinme Jun 22, 2022
5bdd521
Update ValidationCertificateHostMismatch.ql
ihsinme Jun 26, 2022
6b7440f
Update test.cpp
ihsinme Jun 26, 2022
d09de26
Update test1.cpp
ihsinme Jun 26, 2022
26b87b8
Update test2.cpp
ihsinme Jun 26, 2022
6c9936c
Update test2.cpp
ihsinme Jul 3, 2022
1502506
Update ValidationCertificateHostMismatch.expected
ihsinme Aug 3, 2022
2257206
Merge branch 'main' into ihsinme-patch-101
aibaars Aug 29, 2022
03f532d
Merge branch 'main' into ihsinme-patch-101
MathiasVP Oct 4, 2022
90de155
Merge branch 'main' into ihsinme-patch-101
MathiasVP Oct 10, 2022
588b80e
Merge branch 'main' into ihsinme-patch-101
MathiasVP Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test1.cpp
  • Loading branch information
@ihsinme
ihsinme authored Jun 26, 2022
commit d09de269a0e19d0e918399da99a61f819fbf3f7f
4 changes: 1 addition & 3 deletions cpp/ql/test/experimental/query-tests/Security/CWE/CWE-297/semmle/tests/test1.cpp
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@ int gnutls_x509_crt_check_hostname2(gnutls_x509_crt_t cert,const char *hostname,
int gnutls_certificate_verify_peers(gnutls_session_t session);
int gnutls_certificate_verify_peers2(gnutls_session_t session, int * status);
int gnutls_certificate_verify_peers3(gnutls_session_t session, const char * hostname, int * status);
/*
int goodTest1(gnutls_session_t session, gnutls_x509_crt_t cert){ // GOOD
if(gnutls_certificate_verify_peers(session)<0)
return 1;
@@ -35,7 +34,7 @@ int goodTest3(gnutls_session_t session, gnutls_x509_crt_t cert){ // GOOD
return 1;
if (gnutls_x509_crt_init (&cert) < 0)
return 1;
if (!gnutls_x509_crt_check_hostname2 (cert, "hostname"))
if (!gnutls_x509_crt_check_hostname2 (cert, "hostname", status))
return 1;
return 0;
}
@@ -45,7 +44,6 @@ int goodTest4(gnutls_session_t session){ // GOOD
return 1;
return 0;
}
*/
int badTest1(gnutls_session_t session){ // BAD
int status;
if(gnutls_certificate_verify_peers3(session,NULL,&status)<0)