[C#] CWE-348: Using a client-supplied IP address in a security check #9339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi, any updates? |
hvitved
reviewed
Aug 9, 2022
| } | ||
| } | ||
|
|
||
| string clientIpParameterName() { |
| ] | ||
| } | ||
|
|
||
| string getIpAddressRegex() { |
| * | ||
| * For example: `[FromHeader(Name = "X-Forwarded-For")]`. | ||
| */ | ||
| private class AspNetCoreActionMethodParameterSource extends ClientSuppliedIpUsedInSecurityCheckSource, |
There was a problem hiding this comment.
There should be a test for this.
Comment on lines
+52
to
+53
| p.getAnAttribute().getType().hasQualifiedName("Microsoft.AspNetCore.Mvc.FromHeaderAttribute") and | ||
| p.getAnAttribute().getNamedArgument("Name").(StringLiteral).getValue().toLowerCase() = |
There was a problem hiding this comment.
Presumably this should be the same attribute? So introduce a new Attribute a variable and change to
a = p.getAnAttribute() and
a.getType().hasQualifiedName("Microsoft.AspNetCore.Mvc.FromHeaderAttribute") and
a.getNamedArgument("Name").(StringLiteral).getValue().toLowerCase() = clientIpParameterName()| exists(RemoteFlowSource rfs, MethodCall mc | | ||
| rfs.asExpr() = mc.getQualifier() and | ||
| mc.getArgument(0).(StringLiteral).getValue().toLowerCase() = clientIpParameterName() and | ||
| this.getExpr() = mc |
There was a problem hiding this comment.
So shouldn't it be xHeader that is the source in this case, and not the method call itself?
| // `Request.Headers.TryGetValue("X-Forwarded-For", out var xHeader)` | ||
| exists(RemoteFlowSource rfs, MethodCall mc | | ||
| rfs.asExpr() = mc.getQualifier() and | ||
| mc.getArgument(0).(StringLiteral).getValue().toLowerCase() = clientIpParameterName() and |
There was a problem hiding this comment.
mc.getTarget().getName() = "TryGetValue"?
Comment on lines
+79
to
+80
| mc.getQualifier().(StringLiteral).getValue() instanceof PrivateHostName and | ||
| not mc.getQualifier().(StringLiteral).getValue() = "0:0:0:0:0:0:0:1" |
There was a problem hiding this comment.
The StringLiteral infix casts should not be needed.
| } | ||
|
|
||
| /** A data flow sink for sql operation. */ | ||
| private class SqlOperationSink extends ClientSuppliedIpUsedInSecurityCheckSink { |
There was a problem hiding this comment.
Why is that relevant for this query?
| mc.getArgument(0).(MethodCall).getTarget() = s.getSplitMethod() and | ||
| not mc.getTarget() | ||
| .hasQualifiedName("System.Linq.Enumerable", | ||
| ["FirstOrDefault<System.String>", "First<System.String>"]) |
There was a problem hiding this comment.
I believe it should be just
["FirstOrDefault<>", "First<>"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This merge request ports these two similar queries to C#: