Skip to content

[Do not Merge] typo: Double words #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

nschonni
Copy link

@nschonni nschonni commented Dec 3, 2020

Opening this as a PR as it's easier to show all the places than trying to point to lines so you can trace back to the upstream sources

@nschonni nschonni changed the title typo: Double words [Do not Merge] typo: Double words Dec 3, 2020
@imwiss
Copy link
Contributor

imwiss commented Dec 4, 2020

Thanks @nschonni! I've added it to our backlog so that we can address this at the source. Appreciate you opening the PR.

@xuorig xuorig closed this Jan 13, 2021
@nschonni
Copy link
Author

FYI, just reran vale on the head of the default branch and still got these hits

←[4mdescriptions\ghes-2.18\ghes-2.18.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\api.github.com\api.github.com.json←[0m
 3563:66    ←[31merror←[0m  'that' is repeated!  Vale.Repetition
 39685:344  ←[31merror←[0m  'for' is repeated!   Vale.Repetition


 ←[4mdescriptions\ghes-2.19\ghes-2.19.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition 


 ←[4mdescriptions\ghes-2.20\ghes-2.20.json←[0m
 2240:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.18\dereferenced\ghes-2.18.deref.json←[0m
 4448:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.19\dereferenced\ghes-2.19.deref.json←[0m
 4450:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition 


 ←[4mdescriptions\ghes-2.21\ghes-2.21.json←[0m
 2240:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.20\dereferenced\ghes-2.20.deref.json←[0m
 4446:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\api.github.com\dereferenced\api.github.com.deref.json←[0m
 18273:66    ←[31merror←[0m  'that' is repeated!  Vale.Repetition
 267566:344  ←[31merror←[0m  'for' is repeated!   Vale.Repetition


 ←[4mdescriptions\ghes-2.22\ghes-2.22.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!   Vale.Repetition
 5111:66   ←[31merror←[0m  'that' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-3.0\ghes-3.0.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!   Vale.Repetition
 5820:66   ←[31merror←[0m  'that' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.21\dereferenced\ghes-2.21.deref.json←[0m
 4446:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.22\dereferenced\ghes-2.22.deref.json←[0m
 4450:232  ←[31merror←[0m  'the' is repeated!   Vale.Repetition
 21369:66  ←[31merror←[0m  'that' is repeated!  Vale.Repetition 


 ←[4mdescriptions\ghes-3.0\dereferenced\ghes-3.0.deref.json←[0m
 4450:232  ←[31merror←[0m  'the' is repeated!   Vale.Repetition
 23645:66  ←[31merror←[0m  'that' is repeated!  Vale.Repetition 
```

@xuorig
Copy link

xuorig commented Jan 13, 2021

Oops didnt mean to close this @nschonni! Re opening.

@nschonni
Copy link
Author

@xuorig no worries, I rebased and added some new ones so it's easier to trace back to the source strings

@ahoglund
Copy link
Contributor

ahoglund commented Feb 2, 2021

Resolved by #199

@ahoglund ahoglund closed this Feb 2, 2021
@nschonni
Copy link
Author

nschonni commented Feb 2, 2021

@ahoglund there are still a few

$ vale .

 ←[4mdescriptions\ghes-2.18\dereferenced\ghes-2.18.deref.yaml←[0m
 2791:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.18\ghes-2.18.yaml←[0m
 1639:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.18\ghes-2.18.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.18\dereferenced\ghes-2.18.deref.json←[0m
 4448:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.22\dereferenced\ghes-2.22.deref.yaml←[0m
 2792:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.22\ghes-2.22.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-2.22\ghes-2.22.yaml←[0m
 1639:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-3.0\dereferenced\ghes-3.0.deref.yaml←[0m
 2792:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-3.0\ghes-3.0.json←[0m
 2244:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-3.0\ghes-3.0.yaml←[0m
 1639:25  ←[31merror←[0m  'the' is repeated!  Vale.Repetition 


 ←[4mdescriptions\ghes-2.22\dereferenced\ghes-2.22.deref.json←[0m
 4450:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition


 ←[4mdescriptions\ghes-3.0\dereferenced\ghes-3.0.deref.json←[0m
 4450:232  ←[31merror←[0m  'the' is repeated!  Vale.Repetition

✖ ←[31m12 errors←[0m, ←[33m0 warnings←[0m and ←[34m0 suggestions←[0m in 44 files.

@nschonni nschonni deleted the vale branch February 2, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants