Skip to content

ci: setup release notifications via https://github.com/apps/openapi-release-notifier #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Sep 16, 2020

No description provided.

the error is already logged, no need to throw it again
@gr2m
Copy link
Contributor Author

gr2m commented Sep 17, 2020

@zeke @xuorig this is ready from my side, what's left is

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the secrets. Looks good to me! 🐑

- uses: actions/setup-node@v1
with:
node-version: 14
- run: npm ci
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this won't work unless we add a package.json and package-lock.json to the project.

As a simple workaround, we could replace this with

Suggested change
- run: npm ci
- run: npm install @octokit/auth-app @octokit/core @octokit/plugin-paginate-rest

The more elegant solution will be to encapsulate the code from release-notifier into a reusable action itself, something I planned on doing for a long time now anyway, can as well do it now

@gr2m
Copy link
Contributor Author

gr2m commented Nov 6, 2020

@xuorig I greatly simplified the action by using https://github.com/gr2m/release-notifier-action

But this will not work until we add a personal access token with the Create Release step, otherwise the release workflow will not be triggered

- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: ${{ github.ref }}
draft: false
prerelease: false

@gr2m
Copy link
Contributor Author

gr2m commented Nov 10, 2020

@xuorig @imwiss this is becoming a blocker for migrating Octokit to consume the new OpenAPI spec

@imwiss
Copy link
Contributor

imwiss commented Nov 10, 2020

@xuorig @imwiss this is becoming a blocker for migrating Octokit to consume the new OpenAPI spec

Thanks @gr2m. We'll look into this on Thursday as tomorrow is a holiday 👍

@xuorig
Copy link

xuorig commented Nov 12, 2020

@gr2m I'm not sure if i understand this comment: #34 (comment)

Is this PR safe to ship in its current state?

@xuorig
Copy link

xuorig commented Nov 12, 2020

Chatted with Gregor, this is good to go. Thanks @gr2m !

@xuorig xuorig merged commit 3e4dbc7 into github:main Nov 12, 2020
@xuorig
Copy link

xuorig commented Nov 12, 2020

Updated the token to a PAT a37684d

@gr2m gr2m deleted the release-notifier branch November 12, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants