-
Notifications
You must be signed in to change notification settings - Fork 265
ci: setup release notifications via https://github.com/apps/openapi-release-notifier #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the error is already logged, no need to throw it again
@zeke @xuorig this is ready from my side, what's left is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the secrets. Looks good to me! 🐑
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 14 | ||
- run: npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized this won't work unless we add a package.json
and package-lock.json
to the project.
As a simple workaround, we could replace this with
- run: npm ci | |
- run: npm install @octokit/auth-app @octokit/core @octokit/plugin-paginate-rest |
The more elegant solution will be to encapsulate the code from release-notifier
into a reusable action itself, something I planned on doing for a long time now anyway, can as well do it now
@xuorig I greatly simplified the action by using https://github.com/gr2m/release-notifier-action But this will not work until we add a personal access token with the rest-api-description/.github/workflows/release.yml Lines 19 to 28 in eb38dd3
|
@gr2m I'm not sure if i understand this comment: #34 (comment) Is this PR safe to ship in its current state? |
Chatted with Gregor, this is good to go. Thanks @gr2m ! |
Updated the token to a PAT a37684d |
No description provided.