Skip to content

Commit f9f9246

Browse files
asgerfaeisenberg
andauthored
Apply suggestions from code review
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
1 parent 7b113a2 commit f9f9246

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

extensions/ql-vscode/src/log-insights/performance-comparison.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
124124
case "COMPUTED_EXTENSIONAL": {
125125
if (predicateName.startsWith("cached_")) {
126126
// Add a dependency from a cached COMPUTED_EXTENSIONAL to the predicate with the actual contents.
127-
// The raHash of the this event may appear in a CACHE_HIT events in the other event log. The dependency
127+
// The raHash of the this event may appear in a CACHE_HIT event in the other event log. The dependency
128128
// we're adding here is needed in order to associate the original predicate with such a cache hit.
129129
const originalName = predicateName.substring("cached_".length);
130130
const originalIndex = this.nameToIndex.get(originalName);

extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class ComparisonDataset {
159159
const name = other.data.names[otherCacheHit];
160160
const ownIndex = this.nameToIndex.get(name);
161161
if (ownIndex != null) {
162-
visit(ownIndex, this.data.raHashes[ownIndex]);
162+
visit(ownIndex, raHashes[ownIndex]);
163163
}
164164
}
165165
}

0 commit comments

Comments
 (0)