Avoid unhandled errors in build streams #4009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.pipe()
method on Node.js streams have a gotcha in that they do not propagate errors downstream. This PR changes a few uses of.pipe()
in our build scripts to the more modernstream.pipeline()
, which propagates errors correctly.Previously, if compilation failed with an error, the error would not be visible to Gulp because Gulp only sees the stream that writes to a file, not the intermediate 'esbuild' stream that generated the error. This resulted in unhelpful errors of the form:
Now that the errors is propagated correctly, the TypeScript build error is surfaced correctly. In my concrete case this became the build error