[API] Cannot create a pending review without body (but with a file comment)

[PhenX]

• Gitea version (or commit ref): 1.13.6
• Git version: 2.25.1
• Operating system: Ubuntu 20.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes :
  • https://try.gitea.io/fnetx/Documentation/pulls/126 / https://try.gitea.io/api/swagger#/repository/repoCreatePullReview (see screenshot for details)
  • No
• Log gist: N/A

Description

Hello, while using the repo/CreatePullReview API it seems we cannot create a pending review with file comments only :

gitea/routers/api/v1/repo/pull_review.go

Line 498 in ab77a24

ctx.Error(http.StatusUnprocessableEntity, "", fmt.Errorf("review event %s need body", event))

This also seems to mean that the review, event if "pending" is "published" and sends notifications and is visble in the history.

This behaviour is annoying and prevents a correct usage of file reviews via the API IMHO.

What I need to do is : be able to start pending reviews with file comments, and publish the review only when submitting the review with one of these statuses : Commented, Rejected, Approved.

Or is there something I'm doing wrong ?

[noerw]

The unwanted body requirement comes from here:

gitea/routers/api/v1/repo/pull_review.go

Lines 497 to 498 in 3021d3a

	if reviewType != models.ReviewTypeApprove && len(strings.TrimSpace(body)) == 0 {
	ctx.Error(http.StatusUnprocessableEntity, "", fmt.Errorf("review event %s need body", event))

The fact that the pending review is published is because CreateReview() calls pull.SubmitReview(), which in turn also sends timeline comments, notifications, mentions etc; clearly the wrong function.

gitea/routers/api/v1/repo/pull_review.go

Lines 361 to 362 in 3021d3a

	// create review and associate all pending review comments
	review, _, err := pull_service.SubmitReview(ctx.User, ctx.Repo.GitRepo, pr.Issue, reviewType, opts.Body, opts.CommitID)

gitea/services/pull/review.go

Lines 217 to 218 in 3021d3a

	// SubmitReview creates a review out of the existing pending review or creates a new one if no pending review exist
	func SubmitReview(doer *models.User, gitRepo *git.Repository, issue *models.Issue, reviewType models.ReviewType, content, commitID string) (*models.Review, *models.Comment, error) {

There is no pull.CreateReview() function to be used instead.. To fix this, we'd need to create it, which just calls models.CreateReview() and pull.createCodeComment()

edit: this might partially be a regression of #14218?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[PhenX]

Still relevant. Any new about this change?

[wxiaoguang]

It should have been fixed.