Avatars not visible in commit view when no-reply address is configured to the real domain

[smartEBL]

Description

This is basically the same problem as being reported by #33595

There are two observations:

• The icons (custom ones) are not correctly displayed - nearly all of them show the "default" one. This happens in the commit view in the "Code" tab of a repo, as well as in the commit view of any Pull request.
• The link behind the commit author is broken and will lead to a 404 page.

In our setup we use ldap for authentication. The gitea usernames are lastname, while the email addresses are firstname.lastname@company.bla.
The link created for a user will be http://gitea:3000/firstname lastname - which does not exist. Instead it should be http://gitea:3000/lastname.

In some cases this link creation works - if the user misconfigured his git email address to lastname@company.bla instead of firstname.lastname@company.bla.

Gitea Version

1.24.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

2.49.0

Operating System

Ubuntu 22.04

How are you running Gitea?

Gitea 1.24.2 via docker compose with SQLite database

Database

SQLite

[wxiaoguang]

Can you check whether the email firstname.lastname@company.bla in database (the email_address table) is active or not?

[smartEBL]

Can you check whether the email firstname.lastname@company.bla in database (the email_address table) is active or not?

Hey. Thanks for the super quick response!
The email address has is_activated and also is_primary set as 1

[wxiaoguang]

That's strange, the bug should have been fixed in 1.24

The logic overall looks like this:

gitea/models/user/user.go

Line 1172 in c6467ed

func GetUsersByEmails(ctx context.Context, emails []string) (*EmailUserMap, error) {

gitea/models/user/user.go

Line 1225 in c6467ed

func GetUserByEmail(ctx context.Context, email string) (*User, error) {

• Get committer email from git commit
• Search it from email_address table bye WHERE lower_email = {git email} AND is_active=true, then get related users
• The code is covered by some tests and is tested on gitea.com and by some other users (well, maybe no LDAP was involved)

So without a reproduce sample, it's difficult for me to figure out what happens ....

Are you able to provide more clues, or a reproducible setup?

[wxiaoguang]

In some cases this link creation works - if the user misconfigured his git email address to lastname@company.bla instead of firstname.lastname@company.bla.

That's the most strange part. It shows that the GetUsersByEmails/GetUserByEmail does do their work.

So need to figure out why firstname.lastname@company.bla is different. Where it mismatches? (if you are surely using 1.24)

[smartEBL]

(if you are surely using 1.24)

Yes, it's 1.24.2 for sure.

Maybe the fact that the generated link which should point to the user page contains Firstname Lastname (db field full_name) instead of lastname (db field lower_name) might be a hint.

So instead of
http://gitea:3000/Firstname Lastname (what we see right now)
we would expect
http://gitea:3000/lastname

fyi: We did the migration from 1.23.8 to 1.24.2 in the morning - maybe something went wrong there also?

[hiifong]

Please use git config --global --list to check if the email address matches the one on gitea.

[wxiaoguang]

Maybe the fact that the generated link which should point to the user page contains Firstname Lastname (db field full_name) instead of lastname (db field lower_name) might be a hint.

I don't think it is the case.

The details are:

• Git commit contains git user and git email (provided by each user)
• Gitea has user's gitea_username and gitea_email

Gitea needs to use git email to find a related Gitea user by its gitea_email, and render the link http://gitea-host/{gitea_username}. If it can't find the Gitea user by git email, then it renders the link as http://gitea-host/{git user}

[smartYSC]

We figured it out (I'm the colleague of @smartEBL):

In our config NO_REPLY_ADDRESS is set to company.bla.

GetUsersByEmails() check if the git email ends with @NO_REPLY_ADDRESS:

gitea/models/user/user.go

Lines 1180 to 1183 in c6467ed

	if strings.HasSuffix(email, "@"+setting.Service.NoReplyAddress) {
	username := strings.TrimSuffix(email, "@"+setting.Service.NoReplyAddress)
	needCheckUserNames.Add(strings.ToLower(username))
	} else {

This is true for all our users.

It then decides to check the user name instead of the email address:

gitea/models/user/user.go

Lines 1215 to 1217 in c6467ed

	if err := db.GetEngine(ctx).In("lower_name", needCheckUserNames.Values()).Find(&users); err != nil {
	return nil, err
	}

This finds no results.

Afterwards some other piece of code I have not found yet decides to use the git user in the commit list, which is similar to the behaviour of v1.23. However, it creates a link to the git user which I think it should not do (and did not do in v1.23).

We now changed NO_REPLY_ADDRESS to noreply.company.bla. And the commit list is fixed.

So our issue is resolved.

[wxiaoguang]

Awesome, it explains everything, thank you very much.

However, it creates a link to the git user which I think it should not do (and did not do in v1.23).

I think the root problem is the changed behavior (regression) caused by Improve commits list performance to reduce unnecessary database queries (#33528) also cc @lunny