Skip to content

support the open-icon of folder (#34168) #34896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #34168 by @kerwin612

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 29, 2025
@GiteaBot GiteaBot added this to the 1.24.3 milestone Jun 29, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2025
@GiteaBot GiteaBot requested review from hiifong and lunny June 29, 2025 01:20
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 29, 2025
@wxiaoguang
Copy link
Contributor

Why backport?

@lunny
Copy link
Member

lunny commented Jun 29, 2025

Because some folders have inconsistent icons in v1.24. This is a screenshot from v1.24. Contrib folder has an inconsistent icon with other folder which is ugly.
image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2025
@wxiaoguang
Copy link
Contributor

Because some folders have inconsistent icons in v1.24. This is a screenshot from v1.24. Contrib folder has an inconsistent icon with other folder which is ugly.

Are you sure these changes are well tested and there is no other following up fixes on the main branch?

@lunny
Copy link
Member

lunny commented Jun 30, 2025

Used for a while in gitea.com and I personally couldn't find problems. I checked changed files in this PR and couldn't find related bug fixes in main branch after the PR.

@silverwind silverwind merged commit 89dfed3 into go-gitea:release/v1.24 Jun 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants