Skip to content

Support getting last commit message using contents-ext API #34904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2025
Merged

Support getting last commit message using contents-ext API #34904

merged 9 commits into from
Jul 3, 2025

Conversation

rickyma
Copy link
Contributor

@rickyma rickyma commented Jun 30, 2025 •
edited by wxiaoguang
Loading

Fix #34870
Fix #34929

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 30, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 30, 2025
@rickyma
Copy link
Contributor Author

rickyma commented Jun 30, 2025

Tested locally:
image

@rickyma
Copy link
Contributor Author

rickyma commented Jun 30, 2025

@wxiaoguang PTAL

@rickyma rickyma force-pushed the issue-34870 branch 3 times, most recently from e848e1d to 6ffe439 Compare June 30, 2025 07:12
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 30, 2025 •
edited
Loading

Will take a look later.

I think I prefer to add a new "includes" option like includes=file_content,last_commit because the "last commit" is a heavy operation. If the caller doesn't need it, then we do not need to spend time on it.

@rickyma
Copy link
Contributor Author

rickyma commented Jun 30, 2025

OK, I'll close this. If you have time, please have this done in your way. :)

@rickyma rickyma closed this Jun 30, 2025
@wxiaoguang wxiaoguang reopened this Jun 30, 2025
@wxiaoguang wxiaoguang self-assigned this Jun 30, 2025
@wxiaoguang wxiaoguang marked this pull request as draft June 30, 2025 13:01
@wxiaoguang wxiaoguang mentioned this pull request Jul 2, 2025
Closed
@wxiaoguang wxiaoguang changed the title Support getting lastCommitMessage using contents-ext API Support getting last commit message using contents-ext API Jul 2, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review July 2, 2025 11:39
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 2, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jul 2, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 2, 2025
lunny
lunny reviewed Jul 2, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 2, 2025
@wxiaoguang wxiaoguang merged commit 6455c82 into go-gitea:main Jul 3, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b963fdf 
* giteaofficial/main:
  Fix http auth header parsing (go-gitea#34936)
  Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928)
  Support getting last commit message using contents-ext API (go-gitea#34904)
  [skip ci] Updated translations via Crowdin
  Exclude devtest.ts from tailwindcss (go-gitea#34935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

contents-ext API does not support passing root directory? Support for lastCommitMessage
4 participants
@rickyma @wxiaoguang @lunny @GiteaBot