Improve html escape

[wxiaoguang]

drop "escape-goat"

[silverwind]

Have you considered https://www.npmjs.com/package/lit-html?

[wxiaoguang]

Have you considered https://www.npmjs.com/package/lit-html?

No, it too heavy and I believe we don't need it

[silverwind]

Have you considered https://www.npmjs.com/package/lit-html?

No, it too heavy and I believe we don't need it

lit-html is pretty light and may have some features we want, thought I have never used it personally.

https://bundlephobia.com/package/lit-html@3.3.0

Also, the lint rule is designed for it:

https://github.com/github/eslint-plugin-github/blob/main/docs/rules/unescaped-html-literal.md

[wxiaoguang]

lit-html is pretty light and may have some features we want, thought I have never used it personally.

But it isn't ... I have read their code.

Another problem is that even if we'd like to introduce lit-html, we still need to refactor the existing code first.

Our existing code like svg just doesn't work with it.

[wxiaoguang]

Also, the lint rule is designed for it:

https://github.com/github/eslint-plugin-github/blob/main/docs/rules/unescaped-html-literal.md

It is designed to be general rule to check "html" prefix.

BTW: the check isn't complete, I proposed an update: https://github.com/github/eslint-plugin-github/pull/639

[wxiaoguang]

@silverwind anything else to address?

Introducing lit-html or not, this PR is always necessary to refactor the existing code. And our html function is a subset of lit-html so it won't block us from introducing lit-html in the future (although I guess no in the near future)