Fix issue filter #34914
Merged
Fix issue filter #34914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
25 tasks
|
|
delvh
approved these changes
Jun 30, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jun 30, 2025
GiteaBot
added
lgtm/done
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jun 30, 2025
`0` is zero value and won't be put into query parameter by QueryBuild Fix go-gitea#34913
wxiaoguang
added
backport/done
|
Manually backported then no need to wait for the bot. It seems the for most time the bot only does the backport then main branch gets another push. |
wxiaoguang
added
the
skip-changelog
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2025
* giteaofficial/main: Fix modal + form abuse (go-gitea#34921) [skip ci] Updated translations via Crowdin Follow file symlinks in the UI to their target (go-gitea#28835) Fix issue filter (go-gitea#34914) Fix: RPM package download routing & missing package version count (go-gitea#34909) Add support for 3D/CAD file formats preview (go-gitea#34794)
silverwind
reviewed
Jul 1, 2025
| @@ -15,7 +15,7 @@ | |||
| <input type="text" placeholder="{{ctx.Locale.Tr "repo.issues.filter_milestone"}}"> | |||
| </div> | |||
| <div class="divider"></div> | |||
| <a class="{{if not $.MilestoneID}}active selected {{end}}item" href="{{QueryBuild $queryLink "milestone" 0}}">{{ctx.Locale.Tr "repo.issues.filter_milestone_all"}}</a> | |||
| <a class="{{if not $.MilestoneID}}active selected {{end}}item" href="{{QueryBuild $queryLink "milestone" NIL}}">{{ctx.Locale.Tr "repo.issues.filter_milestone_all"}}</a> | |||
There was a problem hiding this comment.
Why do we write NIL as uppercase? Shouldn't it work as nil too?
There was a problem hiding this comment.
No, Golang team's strange decision. Template can't use "nil", so we use our template helper function NIL
Maybe related to
https://github.com/golang/go/issues/58326
https://github.com/golang/go/issues/57773
There was a problem hiding this comment.
We do have a few cases of lowercase nil in the templates, and I recall they work:
templates/repo/file_info.tmpl:7: {{if ne .NumLines nil}}
templates/repo/file_info.tmpl:12: {{if ne .FileSize nil}}
templates/repo/issue/view_content.tmpl:8: {{ctx.AvatarUtils.Avatar nil 40}}
templates/repo/issue/view_content/comments.tmpl:21: {{ctx.AvatarUtils.Avatar nil 40}}
templates/repo/diff/comments.tmpl:6: <span class="avatar">{{ctx.AvatarUtils.Avatar nil}}</span>
There was a problem hiding this comment.
That's different. Official document and issue have explained.
There was a problem hiding this comment.
The real example is:
{{$var := nil}}, it fails. We have to use {{$var := NIL}}
wxiaoguang
added a commit
that referenced
this pull request
Jul 3, 2025
bdruth
added a commit
to bdruth/gitea
that referenced
this pull request
Jul 4, 2025
…h/gitea into feature/enhanced-workflow-runs-api * 'feature/enhanced-workflow-runs-api' of github.com:bdruth/gitea: [skip ci] Updated translations via Crowdin Follow file symlinks in the UI to their target (go-gitea#28835) Fix issue filter (go-gitea#34914) Fix: RPM package download routing & missing package version count (go-gitea#34909) Add support for 3D/CAD file formats preview (go-gitea#34794) Add a `login`/`login-name`/`username` disambiguation to affected endpoint parameters and response/request models (go-gitea#34901) Improve tags list page (go-gitea#34898) [skip ci] Updated translations via Crowdin docs: fix typo in pull request merge warning message text (go-gitea#34899) Refactor container package (go-gitea#34877) [skip ci] Updated translations via Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0is zero value and won't be put into query parameter by QueryBuildFix #34913