Skip to content

x/build/cmd/relui: bypass trybots for VERSION file CLs #73614

Closed
@dmitshur

Description

@dmitshur

This is an enhancement to speed up the release process and slightly reduce its resource use, by adding some complexity to its implementation that lets it avoid duplicate work.

The Go build system uses the VERSION file to set a development Go version in every pre-submit and post-submit build it runs:

https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/experimental/golangbuild/buildmode.go;l=120-121;drc=6995a8ca0e35918f8fe94d6069daa6141139a5e8

Relui takes this into account and sets the VERSION file content to match the release itself when running its own release tests (here). However, it doesn't take it into account when creating auto-submit CLs that check in the updated VERSION file content to release branches, starting the usual trybots on them which in turn adds time to the process and doesn't test anything that hasn't already been tested.

We can probably make VersionTasks.CreateAutoSubmitVersionCL somewhat smarter about this and bypass trybots for those VERSION file CLs.

CC @golang/release.

Metadata

Metadata

Assignees

Labels

Buildersx/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.NeedsFixThe path to resolution is known, but the work has not been done.

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions