x/tools/gopls/internal/telemetry/cmd/stacks: TestUpdateIssues/open_issue failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestUpdateIssues/open_issue"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUpdateIssues/open_issue
2025/06/02 22:41:42 cloning tools@gopls/v0.16.1
2025/06/02 22:41:46 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/02 22:42:48 building: exit status 1 (rm -fr /tmp/stacks-cache?)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestUpdateIssues/open_issue"

2025-06-02 18:47 x_tools-gotip-darwin-amd64-longtest tools@bcaee630 go@49f63047 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/02 22:41:42 cloning tools@gopls/v0.16.1
2025/06/02 22:41:46 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/02 22:42:48 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 19:39 x_tools-gotip-darwin-amd64-longtest tools@8675e27c go@49f63047 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/02 21:27:02 cloning tools@gopls/v0.16.1
2025/06/02 21:27:06 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/02 21:28:17 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-darwin-arm64-longtest tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 07:39:22 cloning tools@gopls/v0.16.1
2025/06/03 07:39:24 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 07:39:46 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-linux-386-longtest tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 14:44:22 cloning tools@gopls/v0.16.1
2025/06/03 14:44:23 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -64 of type int64)
2025/06/03 14:44:38 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-linux-amd64-longtest tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 14:47:01 cloning tools@gopls/v0.16.1
2025/06/03 14:47:02 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 14:47:15 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-linux-amd64-longtest-aliastypeparams tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 14:50:10 cloning tools@gopls/v0.16.1
2025/06/03 14:50:11 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 14:50:25 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-linux-amd64-longtest-race tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 14:51:31 cloning tools@gopls/v0.16.1
2025/06/03 14:51:32 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 14:51:47 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-02 21:46 x_tools-gotip-linux-arm64-longtest tools@effd83eb go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 14:46:33 cloning tools@gopls/v0.16.1
2025/06/03 14:46:33 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 14:46:45 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-darwin-arm64-longtest tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 08:13:50 cloning tools@gopls/v0.16.1
2025/06/03 08:13:53 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 08:14:27 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-linux-386-longtest tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 15:17:33 cloning tools@gopls/v0.16.1
2025/06/03 15:17:34 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -64 of type int64)
2025/06/03 15:17:48 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-linux-amd64-longtest tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 15:16:45 cloning tools@gopls/v0.16.1
2025/06/03 15:16:46 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 15:16:58 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-linux-amd64-longtest-aliastypeparams tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 15:16:49 cloning tools@gopls/v0.16.1
2025/06/03 15:16:50 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 15:17:03 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-linux-amd64-longtest-race tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 15:18:07 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 15:18:24 building: exit status 1 (rm -fr /tmp/stacks-cache?)

2025-06-03 15:05 x_tools-gotip-linux-arm64-longtest tools@c3cb1f13 go@792548a4 x/tools/gopls/internal/telemetry/cmd/stacks.TestUpdateIssues/open_issue [SKIP] (log)

=== RUN   TestUpdateIssues/open_issue
2025/06/03 15:12:11 cloning tools@gopls/v0.16.1
2025/06/03 15:12:12 building golang.org/x/tools/gopls@v0.16.1 with  for /
# golang.org/x/tools/internal/tokeninternal
/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/tools@v0.22.1-0.20240628205440-9c895dd76b34/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
2025/06/03 15:12:25 building: exit status 1 (rm -fr /tmp/stacks-cache?)

— watchflakes

[findleyr]

@adonovan is this fixed?

[adonovan]

The latest crop of flakes are all related to two problems (unreachable code in vet test; negative array length in tokeninternal.FileSet) that are indeed fixed.