Closed
Description
#!stacks
"sigpanic" && "golang.typeDeclContent" && "findRhsTypeDecl"
Issue created by stacks.
// findRhsTypeDecl finds an alias's rhs type and returns its declaration.
// The rhs of an alias might be an alias as well, but we feel this is a rare case.
// It returns an empty string if the given obj is not an alias.
func findRhsTypeDecl(ctx context.Context, snapshot *cache.Snapshot, pkg *cache.Package, obj types.Object) (string, error) {
if alias, ok := obj.Type().(*types.Alias); ok {
// we choose Rhs instead of types.Unalias to make the connection between original alias
// and the corresponding aliased type clearer.
// types.Unalias brings confusion because it breaks the connection from A to C given
// the alias chain like 'type ( A = B; B =C ; )' except we show all transitive alias
// from start to the end. As it's rare, we don't do so.
t := alias.Rhs()
switch o := t.(type) {
case *types.Named:
obj = o.Obj()
declPGF1, declPos1, _ := parseFull(ctx, snapshot, pkg.FileSet(), obj.Pos()) <------ missing error check
realTypeDecl, _, err := typeDeclContent(declPGF1, declPos1, obj) <---- panics if declPGF1 is nil
return realTypeDecl, err
}
}
return "", nil
}This stack 33hzqg was reported by telemetry:
crash/crashruntime.gopanic:+69,+0x153runtime.panicmem:=262,+0x2ffruntime.sigpanic:+19,+0x2ccgolang.org/x/tools/gopls/internal/golang.typeDeclContent:+1,+0x2cgolang.org/x/tools/gopls/internal/golang.findRhsTypeDecl:+12,+0xe3golang.org/x/tools/gopls/internal/golang.hover:+389,+0x16f7golang.org/x/tools/gopls/internal/golang.Hover:+4,+0x8bgolang.org/x/tools/gopls/internal/server.(*server).Hover:+30,+0x29bgolang.org/x/tools/gopls/internal/protocol.serverDispatch:+335,+0xc57golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func4:+5,+0x73golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func5:+52,+0x68fgolang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2,+0xbfgolang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3,+0x8fruntime.goexit:+0,+0x3
golang.org/x/tools/gopls@v0.19.0-pre.2 go1.24.3 darwin/arm64 other (1)
Dups: mYeZxQ