Open
Description
Go version
1.24.4
Output of go env in your module/workspace:
AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/home/isopov/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/home/isopov/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1392480512=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/home/isopov/tmp/bazelgotest/go.mod'
GOMODCACHE='/home/isopov/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/isopov/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/isopov/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.24.4'
GOWORK=''
PKG_CONFIG='pkg-config'What did you do?
I write the following test:
package foo
import (
"bytes"
"context"
"runtime/pprof"
"strings"
"sync"
"testing"
)
func TestFoo(t *testing.T) {
start := sync.WaitGroup{}
start.Add(1)
end := sync.WaitGroup{}
end.Add(1)
label := "whatdoyousay"
go func() {
pprof.Do(context.Background(), pprof.Labels(label, "hello"), func(ctx context.Context) {
//time.Sleep(time.Millisecond) //with this wait test passes
start.Done()
end.Wait()
})
}()
start.Wait()
prof := new(bytes.Buffer)
if err := pprof.Lookup("goroutine").WriteTo(prof, 1); err != nil {
t.Fatal(err)
return
}
profileString := prof.String()
if !strings.Contains(profileString, label) {
t.Fatalf("no pprof label %s in goroutine profile %s", label, profileString)
return
}
end.Done()
}
(Also on https://github.com/isopov/pproflabeltest)
And run it with
for run in {1..100}; do go test; done
(Note: go test -count=100 cannot reproduce the problem for me)
What did you see happen?
The output is (with some lines omitted):
PASS
ok github.com/isopov/pproflabeltest 0.001s
...
PASS
ok github.com/isopov/pproflabeltest 0.001s
--- FAIL: TestFoo (0.00s)
foo_test.go:33: no pprof label whatdoyousay in goroutine profile goroutine profile: total 3
1 @ 0x41a761 0x478a01
# 0x41a760 runtime.runfinq+0x0 /usr/local/go/src/runtime/mfinal.go:179
1 @ 0x434131 0x470a7d 0x50c931 0x50c765 0x50958b 0x522da8 0x4dba74 0x478a01
# 0x50c930 runtime/pprof.writeRuntimeProfile+0xb0 /usr/local/go/src/runtime/pprof/pprof.go:796
# 0x50c764 runtime/pprof.writeGoroutine+0x44 /usr/local/go/src/runtime/pprof/pprof.go:755
# 0x50958a runtime/pprof.(*Profile).WriteTo+0x14a /usr/local/go/src/runtime/pprof/pprof.go:377
# 0x522da7 github.com/isopov/pproflabeltest.TestFoo+0x107 /home/isopov/tmp/pproflabeltest/foo_test.go:27
# 0x4dba73 testing.tRunner+0xf3 /usr/local/go/src/testing/testing.go:1792
1 @ 0x4716ce 0x40d225 0x40cdd2 0x4dc991 0x4dec97 0x4dba74 0x4deb74 0x4dd52a 0x52311b 0x43e5eb 0x478a01
# 0x4dc990 testing.(*T).Run+0x430 /usr/local/go/src/testing/testing.go:1859
# 0x4dec96 testing.runTests.func1+0x36 /usr/local/go/src/testing/testing.go:2279
# 0x4dba73 testing.tRunner+0xf3 /usr/local/go/src/testing/testing.go:1792
# 0x4deb73 testing.runTests+0x4b3 /usr/local/go/src/testing/testing.go:2277
# 0x4dd529 testing.(*M).Run+0x649 /usr/local/go/src/testing/testing.go:2142
# 0x52311a main.main+0x9a _testmain.go:45
# 0x43e5ea runtime.main+0x28a /usr/local/go/src/runtime/proc.go:283
FAIL
exit status 1
PASS
ok github.com/isopov/pproflabeltest 0.001s
PASS
...
PASS
ok github.com/isopov/pproflabeltest 0.001s
What did you expect to see?
Only successful passes.