chore: Restrict network-dependent helper to integration tests #4250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callpraths
force-pushed
the
b3923/restrict-get-free-ports-pr
branch
from
9fbda8a to
4feca5b
Compare
|
Hiya, Please let me know if this looks good for a review. I started looking at #4127 next. @kolesnikovae does that sound like a useful next step? Aside: is there a forum for such discussions, other than randomly asking on unrelated issues/PRs? |
simonswine
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
LGTM
@callpraths Thank you for your work on this.
Generally we hang out in #pyroscope for more synchronous discussions. For all async a GitHub issue might be best and sharing it in that channel if we fail to get back to you in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last step towards dropping network dependency from unit-tests.
This commit
GetFreePorts()helper with explicit network dependency to theintegrationpackage to discourage use from unit-tests in the future.Closes #3923