|
| 1 | +- Intros, agreement, note taking volunteers and agenda review |
| 2 | +- Previous meeting action items |
| 3 | + - Updating the typeof process PR https://github.com/graphql/graphql-js-wg/issues/123 |
| 4 | + - Cleaning up bundling changes https://github.com/graphql/graphql-js-wg/issues/124 |
| 5 | + - Alternative proposal to remove instanceof checks https://github.com/graphql/graphql-js-wg/issues/125 |
| 6 | +- Proposal: change default branch to 16.x.x (5m, Benjie) |
| 7 | + - Benjie: Main has been the WIP for GraphQL.JS 17 for a while |
| 8 | + - Benjie: Reason for that being incremental delivery being the big release |
| 9 | + - Benjie: Incremental delivery is under active development after a big pivot |
| 10 | + - Benjie: Currently main is still unstable, folks who want to PR fixes are looking at v17 code |
| 11 | + - Benjie: Recommendation: change default branch to 16.x.x |
| 12 | + - Either we create a v17 branch and make main the v16 release |
| 13 | + - Or we leverage the default dropdown to be 16.x.x |
| 14 | + - Benjie: change default branch to 16.x.x |
| 15 | + - Yaacov: scripts and github action could be impacted |
| 16 | + - Benjie: as far as I know they are not - this is a GitHub only setting |
| 17 | + - Benjie: potential impact is the ones that read the PR’s and look at the labels |
| 18 | + - Action item: Saihaj makes changes in GitHub actions |
| 19 | + - Action item: Benjie changes the default branch setting to be 16.x.x |
| 20 | +- Recent releases (10m, Benjie) |
| 21 | + - Benjie: spent entire day figuring out releases etc to advance oneOf and others |
| 22 | + - Benjie: there were some issues with the publish scripts probably related to the specific computer they were being run on |
| 23 | + - Benjie: infinite loop in one of the validations that was fixed in v16 - went ahead and merged it |
| 24 | + - Benjie: another fix with async and sync resolvers, Ivan fixed it and it never got shipped |
| 25 | + - Benjie: also added the new recommended validation rules |
| 26 | + - Benjie: in v16 we fixed a lot of things relating to oneOf (printing the schema, showing in the introspection, …) |
| 27 | + - Benjie: added thunk support for enum values to support self-referencing in enum values |
| 28 | + - Benjie: v17 a lot of PR’s by Yaacov and also the oneOf fixes |
| 29 | + - Benjie: shipping now works on all of the branches |
| 30 | +- GraphQL.JS maintenance (5m, Jovi) |
| 31 | + - Backporting fixes to GraphQL 17 |
| 32 | + - Benjie: wouldn’t worry too much about putting things on a backlog |
| 33 | + - Benjie: forward porting into v17 hopefully shouldn’t be too much of an issue |
| 34 | + - Getting reviews/merges on pull requests |
| 35 | + - Jovi: we can’t ask for reviews without being a member |
| 36 | + - Action item: Benjie to add Jovi as a member so they can ping the graphql-js/reviewers |
| 37 | + - Getting issues closed |
| 38 | + - Jovi: issues for i.e. v16 don’t close when resolved through a PR |
| 39 | + - Benjie: When we change the default branch this will automatically close again |
| 40 | +- Stack size depth issue (5m, Jovi) |
| 41 | + - Action item: find real world use cases for this change |
0 commit comments