HHH-19558: Fixed support of JDBC Escape Syntax #10369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Jun 26, 2025
Comment on lines
-98
to
+106
| result.append(ch); | ||
| if (escaped) { | ||
| token.append(ch); | ||
| } else { | ||
| result.append(ch); | ||
| } |
There was a problem hiding this comment.
Why this change? Can JDBC escapes contain double quotes?
gavinking
reviewed
Jun 26, 2025
Comment on lines
89
to
+96
| if (!doubleQuoted && !escaped) { | ||
| singleQuoted = !singleQuoted; | ||
| } | ||
| result.append(ch); | ||
| if (escaped) { | ||
| token.append(ch); | ||
| } else { | ||
| result.append(ch); | ||
| } |
There was a problem hiding this comment.
I would write this as:
if (escaped) {
token.append(ch);
}
else {
if (!doubleQuoted) {
singleQuoted = !singleQuoted;
}
result.append(ch);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a proposed fix for https://hibernate.atlassian.net/browse/HHH-19558.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.