-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(firestore): added support for non-default databases #8489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): added support for non-default databases #8489
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, thanks for the PR this looks good. Could you add a few tests for this please?
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Hey there 👋 , if I don't receive an update on whether you will add tests or not I will go and add them myself. (You will still get credited for this PR so don't worry about that). |
This comment was marked as outdated.
This comment was marked as outdated.
Noting from issue thread: If unit tests are a barrier to merge, we need to add them to get this through, user commented that adding them isn't within capacity at the moment |
e4518e6
to
457ebcd
Compare
Description
Adds support for initalizing firestore with a non-default database
Related issues
Fixes #8456
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__