-
Notifications
You must be signed in to change notification settings - Fork 4.2k
VPA: Add tests for the recommender metrics utilities #8143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
VPA: Add tests for the recommender metrics utilities #8143
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chansuke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I think these tests are good for checking the small parts of the metrics code. I'm just wondering if we should also test the metrics in our e2e tests.
@@ -0,0 +1,23 @@ | |||
# Recommender metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing some metrics ( for example the in place feature metrics )
cc @voelzmo |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add tests for the recommender metrics utilities
Which issue(s) this PR fixes:
Fixes #8128
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: