-
Notifications
You must be signed in to change notification settings - Fork 493
Bump Coredns version to include PR https://github.com/coredns/coredns… #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: navnandys The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @navnandys! |
Hi @navnandys. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the bump of github.com/coredns/coredns
from v1.11.3
to v1.12.1
backwards compatible? Looking briefly at https://github.com/coredns/coredns/releases it seems so, but IIRC there have been some surprises in this respect in the past.
/cc @Michcioperz
@@ -4,7 +4,7 @@ go 1.23.0 | |||
|
|||
require ( | |||
github.com/coredns/caddy v1.1.1 | |||
github.com/coredns/coredns v1.11.3 | |||
github.com/coredns/coredns v1.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since go.mod
is modified, go.sum
probably needs some modifications as well (e.g. in the corresponding lines), and similarly for the vendored directory. Possibly some dependencies of coredns need to be bumped as well.
@DamianSawicki: GitHub didn't allow me to request PR reviews from the following users: Michcioperz. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bump Coredns version to include PR
coredns/coredns#6999