Skip to content

Lua: Fix ExternalName services without endpoints. #13430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #13154

/assign Gacko

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/lua Issues or PRs related to lua code needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels May 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2025
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Lua: Fix ExternalName services without endpoints.
/triage accepted
/kind bug
/priority backlog
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title [release-1.11] Lua: Fix ExternalName services without endpoints. Lua: Fix ExternalName services without endpoints. May 28, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels May 28, 2025
@Gacko
Copy link
Member

Gacko commented May 28, 2025

/test pre-ingress-nginx-lua-test

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-ingress-nginx-lua-test b17b868 link true /test pre-ingress-nginx-lua-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Gacko
Copy link
Member

Gacko commented May 28, 2025

I think the Lua test is failing because of a change in the E2E Test Runner image. The NGINX base image it was built on is not matching the one of the release-1.11 branch, as we removed Lua plugins at some point.

tl;dr: If the Lua test is the only thing not working, please see #13154 and #13429. There it worked.

Gacko
Gacko approved these changes May 28, 2025
@k8s-ci-robot k8s-ci-robot changed the title Lua: Fix ExternalName services without endpoints. Lua: Fix ExternalName services without endpoints. May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko Gacko merged commit 9cb7d54 into kubernetes:release-1.11 May 28, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants