Skip to content

add installing makensis in release script #20274

Closed as not planned
Closed as not planned
@medyagh

Description

@medyagh
 -r installers/windows/ out/windows_tmp
cp -r LICENSE out/windows_tmp/LICENSE
awk 'sub("$", "\r")' out/windows_tmp/LICENSE > out/windows_tmp/LICENSE.txt
sed -E -i 's/--VERSION_MAJOR--/'1'/g' out/windows_tmp/minikube.nsi
sed -E -i 's/--VERSION_MINOR--/'35'/g' out/windows_tmp/minikube.nsi
sed -E -i 's/--VERSION_BUILD--/'0'/g' out/windows_tmp/minikube.nsi
sed -E -i 's/--INSTALL_SIZE--/'122892'/g' out/windows_tmp/minikube.nsi
cp out/minikube-windows-amd64.exe out/windows_tmp/minikube.exe
fakeroot dpkg-deb --build /tmp/tmp.KAqnzTVh9Y.minikube_1.35.0-amd64-deb out/minikube_1.35.0-0_amd64.deb
makensis out/windows_tmp/minikube.nsi
make: makensis: Command not found
make: *** [Makefile:647: out/minikube-installer.exe] Error 127
make: *** Waiting for unfinished jobs....
dpkg-deb: building package 'minikube' in 'out/minikube_1.35.0-0_amd64.deb'.
out/docker-machine-driver-hyperkit

I installed it manually using this command:
sudo apt install nsis

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions