-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: YAML file escape error problem #20904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: YAML file escape error problem #20904
Conversation
Hi @LJTian. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
/cc @medyagh |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 50.6s 52.5s 49.0s 47.0s 51.7s Times for minikube ingress: 15.1s 15.1s 15.5s 15.0s 15.0s docker driver with docker runtime
Times for minikube start: 26.7s 25.3s 23.4s 26.1s 22.5s Times for minikube ingress: 12.3s 12.8s 12.8s 12.8s 13.3s docker driver with containerd runtime
Times for minikube (PR 20904) start: 22.0s 20.8s 21.4s 22.0s 22.7s Times for minikube ingress: 38.8s 38.8s 39.8s 40.3s 39.8s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures seem to be flake . LGTM?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ComradeProgrammer, LJTian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @LJTian this fixes the issue |
Problem: faiing test Volcano addon

log file: https://storage.googleapis.com/minikube-builds/logs/20889/39905/Docker_Linux.html#fail_TestAddons%2fserial%2fVolcano
error message:
stderr: The CustomResourceDefinition "hypernodes.topology.volcano.sh" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[members].items.properties[selector].x-kubernetes-validations[1].rule: Invalid value: apiextensions.ValidationRule{Rule:"(has(self.exactMatch) ? 1 : 0) + (has(self.regexMatch) ? 1 : 0) + (has(self.labelMatch) ? 1 : 0) <= 1", Message:"Only one of ExactMatch, RegexMatch, or LabelMatch can be specified", MessageExpression:"", Reason:(*apiextensions.FieldValueErrorReason)(nil), FieldPath:"", OptionalOldSelf:(*bool)(nil)}: compilation failed: ERROR: <input>:1:98: Syntax error: token recognition error at: '&l' | (has(self.exactMatch) ? 1 : 0) + (has(self.regexMatch) ? 1 : 0) + (has(self.labelMatch) ? 1 : 0) <= 1 | .................................................................................................^ ERROR: <input>:1:100: Syntax error: mismatched input 't' expecting <EOF> | (has(self.exactMatch) ? 1 : 0) + (has(self.regexMatch) ? 1 : 0) + (has(self.labelMatch) ? 1 : 0) <= 1 | ...................................................................................................^ ERROR: <input>:1:101: Syntax error: token recognition error at: ';' | (has(self.exactMatch) ? 1 : 0) + (has(self.regexMatch) ? 1 : 0) + (has(self.labelMatch) ? 1 : 0) <= 1 | ....................................................................................................^ ERROR: <input>:1:102: Syntax error: token recognition error at: '= ' | (has(self.exactMatch) ? 1 : 0) + (has(self.regexMatch) ? 1 : 0) + (has(self.labelMatch) ? 1 : 0) <= 1 | .....................................................................................................^ I0605 18:32:10.625580 14557 retry.go:31] will retry after 185.613442ms: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.33.1/kubectl apply -f /etc/kubernetes/addons/volcano-deployment.yaml: Process exited with status 1
Root cause: Problem with escaping of yaml files inside minikube node.
vi /etc/kubernetes/addons/volcano-deployment.yaml
Repair results:

