Skip to content

Use filepath.WalkDir instead of filepath.Walk #34250

@Gofastasf

Description

@Gofastasf

/good-first-issue

What would you like to be added:
filepath.WalkDir where its appropriate.

Why is this needed:
To reduce unnecessary stat call.

Activity

added
kind/featureCategorizes issue or PR as related to a new feature.
on Feb 1, 2025
k8s-ci-robot

k8s-ci-robot commented on Feb 1, 2025

@k8s-ci-robot
Contributor

@Gofastasf:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

What would you like to be added:
filepath.WalkDir where its appropriate.

Why is this needed:
To reduce unnecessary stat call.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

added
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.
on Feb 1, 2025
priyanshikhetwani

priyanshikhetwani commented on Feb 1, 2025

@priyanshikhetwani
Contributor

/assign

removed
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
on Feb 3, 2025
BenTheElder

BenTheElder commented on Feb 3, 2025

@BenTheElder
Member

To reduce unnecessary stat call.

Is this a real problem in our tests / test tools ...?
Please be careful when making this sort of refactor.

Also, this issue has not met the requirements for good-first issue: #34250 (comment)
Generally it should also be accepted by maintainers first, in addition to the requirements outlined for good first issue.

BenTheElder

BenTheElder commented on Feb 3, 2025

@BenTheElder
Member

/sig testing

added
sig/testingCategorizes an issue or PR as relevant to SIG Testing.
and removed
needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.
on Feb 3, 2025
priyanshikhetwani

priyanshikhetwani commented on Mar 21, 2025

@priyanshikhetwani
Contributor

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.sig/testingCategorizes an issue or PR as relevant to SIG Testing.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @BenTheElder@k8s-ci-robot@priyanshikhetwani@Gofastasf

      Issue actions

        Use filepath.WalkDir instead of filepath.Walk · Issue #34250 · kubernetes/test-infra