[12.x] Adds EagerLoad attribute and initializeOnQueue hook
#55590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
timacdonald
changed the title
WithRelations attribute
|
I'm sure you're already on it, but the class name is still |
timacdonald
changed the title
WithRelations attributeLoadRelations attribute
timacdonald
changed the title
LoadRelations attributeLoadRelations and initilizer hooks on on the queue
timacdonald
changed the title
LoadRelations and initilizer hooks on on the queueEagerLoad attribute and initializeOnQueue hook
AndrewMast
reviewed
Apr 30, 2025
| } | ||
| } | ||
|
|
||
| if (in_array(Queueable::class, class_uses_recursive($this)) && method_exists($this, 'initializeOnQueue')) { |
There was a problem hiding this comment.
I feel like swapping the order would be more optimal, but probably not by much:
if (method_exists($this, 'initializeOnQueue') && in_array(Queueable::class, class_uses_recursive($this))) {Probably would only be important if this was called a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.