-
Notifications
You must be signed in to change notification settings - Fork 115
[Footer] Site feature: Layer5 Service Status #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @leecalcote I have added the service status. Please review |
Looks like two PRs on the same topic. Close this duplicate or close PR #528? |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
Thank you @leecalcote . I was trying to fix the DCO error. But I don't think that worked.🤔 |
Follow these instructions: https://github.com/layer5io/docs/pull/527/checks?check_run_id=41594389290 |
@lumenCodes please follow through fixing the dco. |
Thank you @leecalcote |
Signed-off-by: lumencodes <lumenluwiz@gmail.com>
Signed-off-by: lumencodes <lumenluwiz@gmail.com>
f8d1ba7
to
6ecfd16
Compare
I have fixed the DCO @leecalcote and @vishalvivekm |
@@ -387,6 +387,9 @@ | |||
.footer-bottom-right { | |||
margin: 1.5% !important; | |||
} | |||
.misc-links { | |||
padding: 2% !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try without !important?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lumenCodes we're still waiting for you to incorporate the suggestions. |
@vishalvivekm I am still trying to figure out how to make the changes. |
@lumenCodes... ? Where's the hold up? |
@miacycle thank you so much for offering to help. What am I supposed to do? What have I done? I tried setting up the project locally to preview the changes but I could not because of all the requirements that I need to install. I am not sure what else I can do. If there is a way I can run the project without installing all the dependencies. |
Thanks for working on this, @lumenCodes. Another contributor got this item knocked out. See the closed PRs for details. Let's close this PR so that you can move onto the next one. |
This PR fixes #524
Signed commits