Skip to content

[Footer] Site feature: Layer5 Service Status #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lumenCodes
Copy link

Notes for Reviewers

This PR fixes #524

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented May 3, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit c4e4d5c
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/6821df4bae760400084aa884
😎 Deploy Preview https://deploy-preview-527--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lumenCodes
Copy link
Author

Hello @leecalcote I have added the service status.

Please review

@leecalcote
Copy link
Member

Looks like two PRs on the same topic. Close this duplicate or close PR #528?

@leecalcote leecalcote added the issue/dco One or more commits missing sign off. Commits need amended with sign off. label May 4, 2025
Copy link

github-actions bot commented May 4, 2025

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@lumenCodes
Copy link
Author

Thank you @leecalcote .

I was trying to fix the DCO error. But I don't think that worked.🤔

@leecalcote
Copy link
Member

@vishalvivekm
Copy link
Contributor

@lumenCodes please follow through fixing the dco.

@vishalvivekm vishalvivekm added the pr/on hold PR/Issue on hold label May 7, 2025
@lumenCodes
Copy link
Author

Follow these instructions: https://github.com/layer5io/docs/pull/527/checks?check_run_id=41594389290

Thank you @leecalcote
I am working on it now

lumenCodes added 2 commits May 7, 2025 20:07
Signed-off-by: lumencodes <lumenluwiz@gmail.com>
Signed-off-by: lumencodes <lumenluwiz@gmail.com>
@lumenCodes lumenCodes force-pushed the enhancement/lumencodes/524 branch from f8d1ba7 to 6ecfd16 Compare May 7, 2025 19:08
@lumenCodes
Copy link
Author

I have fixed the DCO @leecalcote and @vishalvivekm

@@ -387,6 +387,9 @@
.footer-bottom-right {
margin: 1.5% !important;
}
.misc-links {
padding: 2% !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try without !important?

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get the same appearance going as what is in the layer5.io site's footer.

The following is missing that same styling.
Screenshot 2025-05-07 at 2 12 57 PM

@vishalvivekm
Copy link
Contributor

@lumenCodes we're still waiting for you to incorporate the suggestions.

@lumenCodes
Copy link
Author

@vishalvivekm I am still trying to figure out how to make the changes.

@miacycle
Copy link
Contributor

@lumenCodes... ? Where's the hold up?

@lumenCodes
Copy link
Author

@lumenCodes... ? Where's the hold up?

@miacycle thank you so much for offering to help.

What am I supposed to do?
Replicate the service status as seen on Layer5 website.

What have I done?
I have updated the footer.html file and _footer_project.scsss file to replicate what is on Layer5. in the footer.html

I tried setting up the project locally to preview the changes but I could not because of all the requirements that I need to install.

I am not sure what else I can do. If there is a way I can run the project without installing all the dependencies.

@leecalcote
Copy link
Member

Thanks for working on this, @lumenCodes. Another contributor got this item knocked out. See the closed PRs for details. Let's close this PR so that you can move onto the next one.

@leecalcote leecalcote closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cloud-docs component/kanvas-docs issue/dco One or more commits missing sign off. Commits need amended with sign off. pr/on hold PR/Issue on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Footer] Site feature: Layer5 Service Status
4 participants