Port learning path to hugo compatible markdown #628
Conversation
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
layouts/shortcodes/image.html
Outdated
| {{ $title := .Get "title" | default "" }} | ||
|
|
||
| <div class="image-container" style="text-align: {{ $align }}; margin: 1rem 0;"> | ||
| <img src="{{ $src | safeURL }}" alt="{{ $alt }}" {{ with $title }}title="{{ . }}"{{ end }} style="width: {{ $width }}; max-width: 100%; height: auto; border-radius: 0.5rem; box-shadow: 0 0 0.5rem rgba(0, 179, 159, 0.4);" data-modal="true" onclick="openModal(this)" /> |
There was a problem hiding this comment.
Hi @vishalvivekm,
Great work! I learned a lot from it.✍️
I noticed that the images on these new pages look a bit different from those in the rest of our docs. It seems the inline styles in image.html are overriding the global CSS, causing inconsistent sizing (they appear to be 100% width).
Perhaps we could refactor layouts/shortcodes/image.html to produce a similar HTML structure to our layouts/_default/_markup/render-image.html file. This would ensure that no matter which method is used to add an image, the styling remains the same across the entire site.
What do you think?👀
For comparison:
| Standard Doc Image | New Learning Path Image |
|
|
There was a problem hiding this comment.
reverted inline styles 👍
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Notes for Reviewers
This PR fixes #
https://deploy-preview-628--bejewelled-pegasus-b0ce81.netlify.app/learning-paths/
Signed commits