Make sidebar sticky w/signoff #253
Conversation
Signed-off-by: Ritesh Karankal <ritesh.karankal200@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
✔️ Website preview ready! 🔨 Explore the source changes: 2061dea 🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/6210abebd96d690008f883f8 😎 Browse the preview: https://deploy-preview-253--getnighthawk.netlify.app |
docs/assets/css/sidebar_doc.css
Outdated
| } | ||
|
|
||
| .sidebar { | ||
| position: absolute; | ||
| top: 30px; | ||
| position: absolute; |
There was a problem hiding this comment.
Het @ritesh-karankal you have to change position of this class, also increase the top also
There was a problem hiding this comment.
| position: absolute; | |
| .sidebar{ | |
| position: fixed; | |
| top: 145px; | |
Is it correct?
Signed-off-by: Ritesh Karankal <ritesh.karankal200@gmail.com>
There was a problem hiding this comment.
@ritesh-karankal I think that formatting change can be ignored (if possible) as it is not required and sometimes it makes PR hard to review, else LGTM
|
Oh It was due to vscode extension. I will change it back to previous formatting. @Abhijay007 |
Signed-off-by: Ritesh Karankal <ritesh.karankal200@gmail.com>
|
Thanks for your contribution to the Layer5 community! 🎉
|
Signed-off-by: Ritesh Karankal ritesh.karankal200@gmail.com
Description
This PR fixes #252
Notes for Reviewers
Signed commits