Skip to content

Conversation

omesh-omg
Copy link
Contributor

@omesh-omg omesh-omg commented Nov 21, 2023

Signed-off-by: omesh-omg kumawatomesh4022@gmail.com

Description
addes google tag manager to the top of header
This PR fixes #291

Signed commits

  • Yes, I signed my commits.

Sorry, something went wrong.

Signed-off-by: omesh-omg <kumawatomesh4022@gmail.com>
Copy link

netlify bot commented Nov 21, 2023

Website preview ready!

Name Link
🔨 Latest commit f5bfb4a
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/655bfb4f6a57440008c76844
😎 Deploy Preview https://deploy-preview-349--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Savio629
Copy link
Member

This code needs to be added to all pages of getnighthawk website

@omesh-omg
Copy link
Contributor Author

This code needs to be added to all pages of getnighthawk website

as per what I understood every page uses same file docs.html as a structure so on all the pages it will be visible I have checked in the console as well

@Savio629
about page
image
docs page
image
home page
image

@sandramsc
Copy link
Member

sandramsc commented Dec 12, 2023

CC: @abhijeetgauravm

@omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead?
tag

@omesh-omg
Copy link
Contributor Author

@sandramsc I don't have much knowledge about but the issue was just to add it Google analytics script to the top of the file , I didn't find any other script added in the main branch regarding this

@omesh-omg
Copy link
Contributor Author

I think this will be helpful

@abhijeetgauravm
Copy link
Contributor

CC: @abhijeetgauravm

@omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? tag

Yeah the Google Tag manager script already integrated in the pages, as i can see to the pages of the site. // @ayushthe1 @vishalvivekm @Savio629 Thoughts?

@sandramsc
Copy link
Member

CC: @abhijeetgauravm
@omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? tag

Yeah the Google Tag manager script already integrated in the pages, as i can see to the pages of the site. // @ayushthe1 @vishalvivekm @Savio629 Thoughts?

If the Google tag manager already exists and the initial issue was to add one then the issue wasn't triaged effectively as essentially this wasn't an issue in the first place...

@iArchitSharma
Copy link

iArchitSharma commented Jan 30, 2024

@omesh-omg @sandramsc @abhijeetgauravm
FYI Google Tag Manager ID and Google Analytics Tracking ID are two different components, what we already have is Analytics ID and that is what was asked in the issue
image

@iArchitSharma
Copy link

@omesh-omg @sandramsc @abhijeetgauravm FYI Google Tag Manager ID and Google Analytics Tracking ID are two different components, what we already have is Analytics ID and that is what was asked in the issue image

Closing the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Tag Manager tracking code to all pages
5 participants