-
Notifications
You must be signed in to change notification settings - Fork 118
adding googleTagManager tracking code to all pages omesh-omg issue 291 #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding googleTagManager tracking code to all pages omesh-omg issue 291 #349
Conversation
Signed-off-by: omesh-omg <kumawatomesh4022@gmail.com>
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This code needs to be added to all pages of getnighthawk website |
as per what I understood every page uses same file docs.html as a structure so on all the pages it will be visible I have checked in the console as well @Savio629 |
CC: @abhijeetgauravm @omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? |
@sandramsc I don't have much knowledge about but the issue was just to add it Google analytics script to the top of the file , I didn't find any other script added in the main branch regarding this |
I think this will be helpful |
Yeah the Google Tag manager script already integrated in the pages, as i can see to the pages of the site. // @ayushthe1 @vishalvivekm @Savio629 Thoughts? |
If the Google tag manager already exists and the initial issue was to add one then the issue wasn't triaged effectively as essentially this wasn't an issue in the first place... |
@omesh-omg @sandramsc @abhijeetgauravm |
Closing the PR! |
Signed-off-by: omesh-omg kumawatomesh4022@gmail.com
Description
addes google tag manager to the top of header
This PR fixes #291
Signed commits