feat: Added Carousel to PerformersSection in sistent #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
sudhanshutech
approved these changes
Mar 5, 2025
amitamrutiya
requested changes
Mar 6, 2025
Comment on lines
+268
to
+316
|
|
||
| export const CarouselContainer = styled('div')({ | ||
| display: 'flex', | ||
| overflow: 'hidden', | ||
| scrollBehavior: 'smooth', | ||
| scrollSnapType: 'x mandatory', | ||
| gap: '1rem', | ||
| padding: '1rem 0', | ||
| width: '100%', | ||
| '&::-webkit-scrollbar': { | ||
| display: 'none' | ||
| }, | ||
| scrollbarWidth: 'none', | ||
| '.carousel-item': { | ||
| flex: '0 0 auto', | ||
| scrollSnapAlign: 'center', | ||
| width: 'auto' | ||
| } | ||
| }); | ||
|
|
||
| export const CarouselButton = styled('button')(({ theme }) => ({ | ||
| position: 'absolute', | ||
| top: '50%', | ||
| transform: 'translateY(-50%)', | ||
| zIndex: '1', | ||
| fill: theme.palette.icon.default, | ||
| borderColor: theme.palette.border.normal, | ||
| border: 'none', | ||
| cursor: 'pointer', | ||
| padding: '0.5rem', | ||
| borderRadius: '50%', | ||
| boxShadow: '0 2px 4px rgba(0, 0, 0, 0.2)', | ||
| '&:hover': { | ||
| fill: theme.palette.icon.secondary | ||
| }, | ||
| '&:first-of-type': { | ||
| left: '-2rem' | ||
| }, | ||
| '&:last-of-type': { | ||
| right: '-2rem' | ||
| } | ||
| })); | ||
|
|
||
| export const CarouselWrapper = styled('div')({ | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| width: '100%', | ||
| position: 'relative' | ||
| }); |
There was a problem hiding this comment.
Why in your PR are you not using this new added styled component?
There was a problem hiding this comment.
If it is not used then we don't need that.
|
@Vidit-Kushwaha adding this to websites' meeting agenda items |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR introduces a carousel component to the top performer cards, enhancing the user experience by allowing seamless navigation through multiple top-performing profiles. The carousel will improve content organization, making it easier for users to view and engage with featured performers.
Screen.Recording.2025-03-04.at.6.01.48.PM.mov
Signed commits