[mlir] Linalg MatmulOp::parse crashes

[Anonymous7i0em3yd]

git version: 59fd287

system: Ubuntu 18.04.6 LTS

reproduce with: mlir-opt a.mlir

a.mlir:

func.func @return_inside_func_yield(%t: tensor<?xf16>, %f: vector<4xf16>)
  -> (tensor<?xf16>, vector<4xf16>)
{
  %0 = linalg.matmul ins(%t, %t : tensor<?xf16>, tensor<?xf16>)
                                outs(%f : vector<4xf16>) -> tensor<?xf16>
  func.return %0, %f : tensor<?xf16>, vector<4xf16>
}

module attributes {transform.with_named_sequence} {
  transform.named_sequence @__transform_main(%arg1:!transform.any_op {transform.readonly}) {
      %0 = transform.structured.match ops{["linalg.matmul"]} in %arg1 : (!transform.any_op) ->!transform.any_op
      %1, %2, %3, %loop = transform.structured.tile_using_for %0 tile_sizes [10, 20] : (!transform.any_op) -> (!transform.any_op,!transform.any_op,!transform.any_op,!transform.any_op)
      transform.yield
  }
}

stack trace:

unsupported non numeric type
UNREACHABLE executed at /data/szy/MLIR/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:467!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /data/szy/MLIR/llvm-project/install/bin/mlir-opt --mlir-print-stacktrace-on-diagnostic /data/szy/MLIR/seed/seed28/tmp.IRhPbcw19l.mlir
1.      MLIR Parser: custom op parser 'func.func'
2.      MLIR Parser: custom op parser 'linalg.matmul'
 #0 0x000055c0b519edb8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x11bddb8)
 #1 0x000055c0b519c8be llvm::sys::RunSignalHandlers() (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x11bb8be)
 #2 0x000055c0b519f736 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #3 0x00007fb998b28420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
 #4 0x00007fb99816500b raise /build/glibc-LcI20x/glibc-2.31/signal/../sysdeps/unix/sysv/linux/raise.c:51:1
 #5 0x00007fb998144859 abort /build/glibc-LcI20x/glibc-2.31/stdlib/abort.c:81:7
 #6 0x000055c0b5185f3f (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x11a4f3f)
 #7 0x000055c0b5a4e8fd (anonymous namespace)::RegionBuilderHelper::buildBinaryFn(mlir::linalg::BinaryFn, mlir::Value, mlir::Value) LinalgOps.cpp:0:0
 #8 0x000055c0b5b491f9 mlir::linalg::MatmulOp::regionBuilder(mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x1b681f9)
 #9 0x000055c0b5b6ac1d void llvm::function_ref<void (mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>)>::callback_fn<std::function<void (mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>)>>(long, mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x1b89c1d)
#10 0x000055c0b5b54f33 fillStructuredOpRegion(mlir::OpBuilder&, mlir::Region&, mlir::TypeRange, mlir::TypeRange, llvm::ArrayRef<mlir::NamedAttribute>, llvm::function_ref<void (mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>)>) LinalgOps.cpp:0:0
#11 0x000055c0b5a43573 parseNamedStructuredOp(mlir::OpAsmParser&, mlir::OperationState&, unsigned int, llvm::function_ref<void (mlir::ImplicitLocOpBuilder&, mlir::Block&, llvm::ArrayRef<mlir::NamedAttribute>)>) LinalgOps.cpp:0:0
#12 0x000055c0b5b498af mlir::linalg::MatmulOp::parse(mlir::OpAsmParser&, mlir::OperationState&) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x1b688af)
#13 0x000055c0bb3077e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
#14 0x000055c0bb3129a4 (anonymous namespace)::OperationParser::parseBlock(mlir::Block*&) Parser.cpp:0:0
#15 0x000055c0bb31085c (anonymous namespace)::OperationParser::parseRegion(mlir::Region&, llvm::ArrayRef<mlir::OpAsmParser::Argument>, bool) Parser.cpp:0:0
#16 0x000055c0bb30eacc (anonymous namespace)::CustomOpAsmParser::parseOptionalRegion(mlir::Region&, llvm::ArrayRef<mlir::OpAsmParser::Argument>, bool) Parser.cpp:0:0
#17 0x000055c0bb410e32 mlir::function_interface_impl::parseFunctionOp(mlir::OpAsmParser&, mlir::OperationState&, bool, mlir::StringAttr, llvm::function_ref<mlir::Type (mlir::Builder&, llvm::ArrayRef<mlir::Type>, llvm::ArrayRef<mlir::Type>, mlir::function_interface_impl::VariadicFlag, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&)>, mlir::StringAttr, mlir::StringAttr) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x742fe32)
#18 0x000055c0b58217fa mlir::func::FuncOp::parse(mlir::OpAsmParser&, mlir::OperationState&) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x18407fa)
#19 0x000055c0bb3077e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
#20 0x000055c0bb3065ad mlir::parseAsmSourceFile(llvm::SourceMgr const&, mlir::Block*, mlir::ParserConfig const&, mlir::AsmParserState*, mlir::AsmParserCodeCompleteContext*) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x73255ad)
#21 0x000055c0b81a5f0f mlir::parseSourceFile(std::shared_ptr<llvm::SourceMgr> const&, mlir::Block*, mlir::ParserConfig const&, mlir::LocationAttr*) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41c4f0f)
#22 0x000055c0b81a4e8e mlir::parseSourceFileForTool(std::shared_ptr<llvm::SourceMgr> const&, mlir::ParserConfig const&, bool) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41c3e8e)
#23 0x000055c0b81a467f performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
#24 0x000055c0b81a43ed llvm::LogicalResult llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::$_0>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&) MlirOptMain.cpp:0:0
#25 0x000055c0b824f275 mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x426e275)
#26 0x000055c0b819e405 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd405)
#27 0x000055c0b819e6af mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd6af)
#28 0x000055c0b819e9de mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd9de)
#29 0x000055c0b517d337 main (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x119c337)
#30 0x00007fb998146083 __libc_start_main /build/glibc-LcI20x/glibc-2.31/csu/../csu/libc-start.c:342:3
#31 0x000055c0b517ce9e _start (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x119be9e)

[llvmbot]

@llvm/issue-subscribers-mlir

Author: None (wwy6191)

git version: 59fd287

system: Ubuntu 18.04.6 LTS

reproduce with: mlir-opt --mlir-print-stacktrace-on-diagnostic a.mlir

a.mlir:

#map = affine_map<(d0, d1) -> (d0 + d0 floordiv 8, d1 mod 8)>
#map1 = affine_map<(d0, d1) -> (d1 floordiv 8)>
module {
  spirv.func @<!-- -->simd_insert_scalar_misa(%arg0: i32, %arg1: i32, %arg2: i32) "None" {
    %0 = builtin.unrealized_conversion_cast %arg2 : i32 to index
    %1 = builtin.unrealized_conversion_cast %arg1 : i32 to index
    %2 = builtin.unrealized_conversion_cast %arg0 : i32 to index
    %c0 = arith.constant 0 : index
    %3 = arith.muli %2, %0 : index
    %4 = arith.muli %2, %1 : index
    %5 = affine.min #map(%3, %4)
    %6 = arith.muli %5, %0 : index
    %7 = arith.muli %5, %4 : index
    %8 = affine.apply #map1(%6, %7)
    scf.for %arg3 = %c0 to %8 step %6 {
      %9 = affine.min #map(%6, %7)
      %10 = affine.apply #map1(%5, %9)
      scf.for %arg4 = %c0 to %10 step %5 {
        %11 = affine.apply #map1(%4, %9)
        %12 = arith.muli %arg3, %11 : index
        "test.foo"(%12) : (index) -&gt; ()
      }
      scf.for %arg4 = %11 to %10 step %9 {
        %13 = affine.apply #map1(%4, %12)
        %14 = arith.muli %arg3, %13 : index
        "test.foo"(%14) : (index) -&gt; ()
      }
    }
    scf.for %arg3 = %8 to %5 step %6 {
      %9 = affine.min #map(%6, %7)
      %10 = affine.apply #map1(%5, %9)
      scf.for %arg4 = %c0 to %10 step %5 {
        %11 = affine.apply #map1(%4, %9)

stack trace:

tmp.dlbmYvtohM.mlir:33:41: error: expected operation name in quotes
        %11 = affine.apply #map1(%4, %9)
                                        ^
/data/szy/MLIR/seed/seed15/tmp.dlbmYvtohM.mlir:33:41: note: diagnostic emitted with trace:
 #<!-- -->0 0x0000559eedbb2db8 llvm::sys::PrintStackTrace(llvm::raw_ostream&amp;, int) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x11bddb8)
 #<!-- -->1 0x0000559ef0cf8b0d emitDiag(mlir::Location, mlir::DiagnosticSeverity, llvm::Twine const&amp;) Diagnostics.cpp:0:0
 #<!-- -->2 0x0000559ef0cf8931 mlir::emitError(mlir::Location, llvm::Twine const&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x4303931)
 #<!-- -->3 0x0000559ef3d17d0d mlir::detail::Parser::emitWrongTokenError(llvm::Twine const&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x7322d0d)
 #<!-- -->4 0x0000559ef3d1c62a (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
 #<!-- -->5 0x0000559ef3d269a4 (anonymous namespace)::OperationParser::parseBlock(mlir::Block*&amp;) Parser.cpp:0:0
 #<!-- -->6 0x0000559ef3d2485c (anonymous namespace)::OperationParser::parseRegion(mlir::Region&amp;, llvm::ArrayRef&lt;mlir::OpAsmParser::Argument&gt;, bool) Parser.cpp:0:0
 #<!-- -->7 0x0000559eefa0ea94 mlir::scf::ForOp::parse(mlir::OpAsmParser&amp;, mlir::OperationState&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x3019a94)
 #<!-- -->8 0x0000559ef3d1b7e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
 #<!-- -->9 0x0000559ef3d269a4 (anonymous namespace)::OperationParser::parseBlock(mlir::Block*&amp;) Parser.cpp:0:0
#<!-- -->10 0x0000559ef3d2485c (anonymous namespace)::OperationParser::parseRegion(mlir::Region&amp;, llvm::ArrayRef&lt;mlir::OpAsmParser::Argument&gt;, bool) Parser.cpp:0:0
#<!-- -->11 0x0000559eefa0ea94 mlir::scf::ForOp::parse(mlir::OpAsmParser&amp;, mlir::OperationState&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x3019a94)
#<!-- -->12 0x0000559ef3d1b7e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
#<!-- -->13 0x0000559ef3d269a4 (anonymous namespace)::OperationParser::parseBlock(mlir::Block*&amp;) Parser.cpp:0:0
#<!-- -->14 0x0000559ef3d2485c (anonymous namespace)::OperationParser::parseRegion(mlir::Region&amp;, llvm::ArrayRef&lt;mlir::OpAsmParser::Argument&gt;, bool) Parser.cpp:0:0
#<!-- -->15 0x0000559ef3d22acc (anonymous namespace)::CustomOpAsmParser::parseOptionalRegion(mlir::Region&amp;, llvm::ArrayRef&lt;mlir::OpAsmParser::Argument&gt;, bool) Parser.cpp:0:0
#<!-- -->16 0x0000559ef0083557 mlir::spirv::FuncOp::parse(mlir::OpAsmParser&amp;, mlir::OperationState&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x368e557)
#<!-- -->17 0x0000559ef3d1b7e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
#<!-- -->18 0x0000559ef3d269a4 (anonymous namespace)::OperationParser::parseBlock(mlir::Block*&amp;) Parser.cpp:0:0
#<!-- -->19 0x0000559ef3d246d5 (anonymous namespace)::OperationParser::parseRegion(mlir::Region&amp;, llvm::ArrayRef&lt;mlir::OpAsmParser::Argument&gt;, bool) Parser.cpp:0:0
#<!-- -->20 0x0000559ef0cd9b9e mlir::ModuleOp::parse(mlir::OpAsmParser&amp;, mlir::OperationState&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x42e4b9e)
#<!-- -->21 0x0000559ef3d1b7e4 (anonymous namespace)::OperationParser::parseOperation() Parser.cpp:0:0
#<!-- -->22 0x0000559ef3d1a5ad mlir::parseAsmSourceFile(llvm::SourceMgr const&amp;, mlir::Block*, mlir::ParserConfig const&amp;, mlir::AsmParserState*, mlir::AsmParserCodeCompleteContext*) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x73255ad)
#<!-- -->23 0x0000559ef0bb9f0f mlir::parseSourceFile(std::shared_ptr&lt;llvm::SourceMgr&gt; const&amp;, mlir::Block*, mlir::ParserConfig const&amp;, mlir::LocationAttr*) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41c4f0f)
#<!-- -->24 0x0000559ef0bb8e8e mlir::parseSourceFileForTool(std::shared_ptr&lt;llvm::SourceMgr&gt; const&amp;, mlir::ParserConfig const&amp;, bool) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41c3e8e)
#<!-- -->25 0x0000559ef0bb867f performActions(llvm::raw_ostream&amp;, std::shared_ptr&lt;llvm::SourceMgr&gt; const&amp;, mlir::MLIRContext*, mlir::MlirOptMainConfig const&amp;) MlirOptMain.cpp:0:0
#<!-- -->26 0x0000559ef0bb83ed llvm::LogicalResult llvm::function_ref&lt;llvm::LogicalResult (std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, llvm::raw_ostream&amp;)&gt;::callback_fn&lt;mlir::MlirOptMain(llvm::raw_ostream&amp;, std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, mlir::DialectRegistry&amp;, mlir::MlirOptMainConfig const&amp;)::$_0&gt;(long, std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, llvm::raw_ostream&amp;) MlirOptMain.cpp:0:0
#<!-- -->27 0x0000559ef0c63275 mlir::splitAndProcessBuffer(std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, llvm::function_ref&lt;llvm::LogicalResult (std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, llvm::raw_ostream&amp;)&gt;, llvm::raw_ostream&amp;, llvm::StringRef, llvm::StringRef) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x426e275)
#<!-- -->28 0x0000559ef0bb2405 mlir::MlirOptMain(llvm::raw_ostream&amp;, std::unique_ptr&lt;llvm::MemoryBuffer, std::default_delete&lt;llvm::MemoryBuffer&gt;&gt;, mlir::DialectRegistry&amp;, mlir::MlirOptMainConfig const&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd405)
#<!-- -->29 0x0000559ef0bb26af mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd6af)
#<!-- -->30 0x0000559ef0bb29de mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&amp;) (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x41bd9de)
#<!-- -->31 0x0000559eedb91337 main (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x119c337)
#<!-- -->32 0x00007f0052599083 __libc_start_main /build/glibc-LcI20x/glibc-2.31/csu/../csu/libc-start.c:342:3
#<!-- -->33 0x0000559eedb90e9e _start (/data/szy/MLIR/llvm-project/install/bin/mlir-opt+0x119be9e)

[joker-eph]

The snippet of MLIR is incomplete it seems, can you publish it entirely?

Also what you're posting the backtrace from the diagnostic, it's not clear to me where is the crash?

[Anonymous7i0em3yd]

The snippet of MLIR is incomplete it seems, can you publish it entirely?

Also what you're posting the backtrace from the diagnostic, it's not clear to me where is the crash?

Sry for copy from wrong place. Text edited.

[joker-eph]

The --mlir-print-stacktrace-on-diagnostic is not needed and unrelated, it is a parser crash.

[Anonymous7i0em3yd]

The --mlir-print-stacktrace-on-diagnostic is not needed and unrelated, it is a parser crash.

Got that thx.

[hiraditya]

Here, in function buildBinaryFn(BinaryFn binaryFn, Value arg0, Value arg1)

$ (lldb) p arg0.getType().dump()
vector<4xf16>
$ (lldb) p arg1.getType().dump()
f16

so both types aren't the same.

frame #0: 0x0000555558ee9c77 mlir-opt`(anonymous namespace)::RegionBuilderHelper::buildBinaryFn(this=0x00007fffffff8260, binaryFn=add, arg0=Value @ 0x00007fffffff8120, arg1=Value @ 0x00007fffffff8118) at LinalgOps.cpp:463:45
frame #1: 0x000055555902a937 mlir-opt`mlir::linalg::MatmulOp::regionBuilder(b=0x00007fffffff8490, block=0x0000555566ba3ef0, attrs=ArrayRef<mlir::NamedAttribute> @ 0x00007fffffff8280) at LinalgOps.cpp:3615:14

[hiraditya]

Crash in parsing stage is inside RegionBuilder, now the region builders don't have a way to communicate error to their caller.

// Returns void.
using RegionBuilderFn = llvm::function_ref<void(ImplicitLocOpBuilder &, Block &,
                                                ArrayRef<NamedAttribute>)>;

This looks brittle. Not sure how to handle it without doing a look ahead.