Skip to content

[mlir][spirv] Incomplete handling of memory operands in CoopMatrix memory operations #145485

Open
@IgWod-IMG

Description

@IgWod-IMG

Creating primarily for tracking purposes. It seems that currently CooperativeMatrixStore and CooperativeMatrixLoad have an incomplete handling of MakePointerAvailable and MakePointerVisible. There are two issues:

  1. The verification does not check that NonPrivatePointer is present if any of two aforementioned memory operands are used, but it is enforced by the spec.
  2. Both memory operands (MakePointerAvailable and MakePointerVisible) expect the scope to be provided, but currently none of the memory operations accepts the scope.

Relevant section of the spec: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_memory_operands

This was spotted when working on #145480.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions