Skip to content

[DOCS][BUILDBOT] Bump recommended worker version #144853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paschalis-mpeis
Copy link
Member

Now recommend 3.11.7 to match the #testing-a-builder-config-locally section.

Now recommend 3.11.7 to match the `#testing-a-builder-config-locally`
section.
@DavidSpickett
Copy link
Collaborator

If you are using this worker version with llvm's master currently and it works, then this is fine.

Galina should be the approver though, because I know that the version used for the server right now is not the latest. Need to be sure it's compatible.

@paschalis-mpeis
Copy link
Member Author

Hey @DavidSpickett,

Thanks for your review.

I know that the version used for the server right now is not the latest. Need to be sure it's compatible.

Yes, what you suggest sounds right to me.

To add a bit more context, I had a brief discussion with @gkistanova before opening the PR,
and there was no recollection of any issues with recent versions of buildbot-worker.

So I went ahead and updated the version to match the one suggested in the local configuration.
That said, I'm open to changing both places again, if we think a different recent version would be appropriate.

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case this LGTM, will be good to have them in sync.

@paschalis-mpeis
Copy link
Member Author

Thanks for the approval David. I'll wait @gkistanova to confirm as well.

@paschalis-mpeis
Copy link
Member Author

Merging as there were no objections. This was confirmed outside of this review anyway. Thanks!

@paschalis-mpeis paschalis-mpeis merged commit 2e196a0 into main Jun 26, 2025
9 checks passed
@paschalis-mpeis paschalis-mpeis deleted the users/paschalis-mpeis/docs-buildbot-worker-ver branch June 26, 2025 09:30
anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025
Now recommend 3.11.7 to match the `#testing-a-builder-config-locally`
section.
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
Now recommend 3.11.7 to match the `#testing-a-builder-config-locally`
section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants