-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[libc++] Fix no-localisation CI failure on <complex> #145213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-libcxx Author: Hui (huixie90) ChangesThere are lots of errors in the CI no-localisation build
Full diff: https://github.com/llvm/llvm-project/pull/145213.diff 3 Files Affected:
diff --git a/libcxx/include/complex b/libcxx/include/complex
index e9baec04d9465..d8ec3d95c10ed 100644
--- a/libcxx/include/complex
+++ b/libcxx/include/complex
@@ -260,6 +260,7 @@ template<class T> complex<T> tanh (const complex<T>&);
# include <__cxx03/complex>
#else
# include <__config>
+# include <__cstddef/size_t.h>
# include <__fwd/complex.h>
# include <__fwd/tuple.h>
# include <__tuple/tuple_element.h>
diff --git a/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_element.compile.pass.cpp b/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_element.compile.pass.cpp
index 50c0e0eff1eda..3a220578a074c 100644
--- a/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_element.compile.pass.cpp
+++ b/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_element.compile.pass.cpp
@@ -16,7 +16,7 @@
#include <complex>
#include <concepts>
-template <size_t I, typename C>
+template <std::size_t I, typename C>
concept HasTupleElement = requires { std::tuple_element<I, C>{}; };
struct SomeObject {};
diff --git a/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_size.compile.pass.cpp b/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_size.compile.pass.cpp
index 28dcbe3fc5ecd..1091c6345598e 100644
--- a/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_size.compile.pass.cpp
+++ b/libcxx/test/std/numerics/complex.number/complex.tuple/tuple_size.compile.pass.cpp
@@ -28,7 +28,7 @@ void test() {
using C = std::complex<T>;
static_assert(HasTupleSize<C>);
- static_assert(std::same_as<typename std::tuple_size<C>::value_type, size_t>);
+ static_assert(std::same_as<typename std::tuple_size<C>::value_type, std::size_t>);
static_assert(std::tuple_size<C>() == 2);
}
|
philnik777
approved these changes
Jun 23, 2025
frederick-vs-ja
approved these changes
Jun 23, 2025
ldionne
approved these changes
Jun 24, 2025
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of errors in the CI no-localisation build