Skip to content

[Offload] Fix entry_points.td test #145292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

RossBrunton
Copy link
Contributor

This was broken as part of #144494 , and just needs an update to the
check lines.

This was broken as part of llvm#144494 , and just needs an update to the
check lines.
@llvmbot
Copy link
Member

llvmbot commented Jun 23, 2025

@llvm/pr-subscribers-offload

Author: Ross Brunton (RossBrunton)

Changes

This was broken as part of #144494 , and just needs an update to the
check lines.


Full diff: https://github.com/llvm/llvm-project/pull/145292.diff

1 Files Affected:

  • (modified) offload/test/tools/offload-tblgen/entry_points.td (+2-2)
diff --git a/offload/test/tools/offload-tblgen/entry_points.td b/offload/test/tools/offload-tblgen/entry_points.td
index c69650c2cff1b..c66d5b488b464 100644
--- a/offload/test/tools/offload-tblgen/entry_points.td
+++ b/offload/test/tools/offload-tblgen/entry_points.td
@@ -25,13 +25,13 @@ def : Function {
 // CHECK: ol_result_t{{.*}} FunctionA(
 
 // The entry point should print tracing output if enabled
-// CHECK: if (offloadConfig().TracingEnabled) {
+// CHECK: if (llvm::offload::isTracingEnabled()) {
 // CHECK-NEXT: "---> FunctionA";
 
 // CHECK: Result = llvmErrorToOffloadError(FunctionA_val(ParamA, ParamB));
 
 // Tracing should construct a param struct for printing
-// CHECK: if (offloadConfig().TracingEnabled) {
+// CHECK: if (llvm::offload::isTracingEnabled()) {
 // CHECK: function_a_params_t Params = {&ParamA, &ParamB};
 
 // CHECK: return Result;

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the fix, thanks!

@RossBrunton RossBrunton merged commit 02d2a16 into llvm:main Jun 23, 2025
9 checks passed
miguelcsx pushed a commit to miguelcsx/llvm-project that referenced this pull request Jun 23, 2025
This was broken as part of llvm#144494 , and just needs an update to the
check lines.
Jaddyen pushed a commit to Jaddyen/llvm-project that referenced this pull request Jun 23, 2025
This was broken as part of llvm#144494 , and just needs an update to the
check lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants