[CostModel] Add getShuffleCostImpl. #145373
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea was to have getShuffleCost as the external interface, getIstructionCost would always call it, the existing implementations were moved into getShuffleCostImpl. This would allow targets to override the getShuffleCost if they wanted direct access to the costs, not via the routines that recognize rev/broadcast/etc. Too many tests change though, as getInstructionCost and getShuffleCost can return different values at the moment. Justt putting up to show the diff.
|
Why aren't we just trying to move most of the getInstructionCost shuffle logic into improveShuffleKindFromMask? iirc it can be overridden via CRTP if a target need to, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was to have getShuffleCost as the external interface, getIstructionCost would always call it, the existing implementations were moved into getShuffleCostImpl. This would allow targets to override the getShuffleCost if they wanted direct access to the costs, not via the routines that recognize rev/broadcast/etc.
Too many tests change though, as getInstructionCost and getShuffleCost can return different values at the moment. Not expecting this to be used, just putting up to show the diff.