[mlir][TilingInterface] NFC Improve comment for tiledAndFusedOps member of SCFTileAndFuseResult
#145397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of SCFTileAndFuseResult Comment was a little unclear, hopefully this change is an improvement.
|
@llvm/pr-subscribers-mlir Author: Aaron St George (AaronStGeorge) ChangesComment was a little unclear, hopefully this change is an improvement. Full diff: https://github.com/llvm/llvm-project/pull/145397.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
index 9feb04dbe03c1..7b43aa43c7517 100644
--- a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
+++ b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
@@ -272,9 +272,10 @@ FailureOr<SmallVector<Operation *>> yieldReplacementForFusedProducer(
struct SCFTileAndFuseResult {
/// List of untiled operations that were fused with the tiled consumer.
llvm::SetVector<Operation *> fusedProducers;
- /// List of tiled and fused operations generated. The first one in this list
- /// is guaranteed to be the tiled operations generated during tiling of the
- /// generated operation.
+ /// List of tiled and fused operations generated. The first element is always
+ /// the tiled version of the original consumer operation processed by
+ /// `tileConsumerAndFuseProducersUsingSCF`, followed by any operations that
+ /// were fused with it.
llvm::SetVector<Operation *> tiledAndFusedOps;
/// The `scf.for` operations that iterate over the tiles.
SmallVector<LoopLikeOpInterface> loops;
|
|
@llvm/pr-subscribers-mlir-scf Author: Aaron St George (AaronStGeorge) ChangesComment was a little unclear, hopefully this change is an improvement. Full diff: https://github.com/llvm/llvm-project/pull/145397.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
index 9feb04dbe03c1..7b43aa43c7517 100644
--- a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
+++ b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
@@ -272,9 +272,10 @@ FailureOr<SmallVector<Operation *>> yieldReplacementForFusedProducer(
struct SCFTileAndFuseResult {
/// List of untiled operations that were fused with the tiled consumer.
llvm::SetVector<Operation *> fusedProducers;
- /// List of tiled and fused operations generated. The first one in this list
- /// is guaranteed to be the tiled operations generated during tiling of the
- /// generated operation.
+ /// List of tiled and fused operations generated. The first element is always
+ /// the tiled version of the original consumer operation processed by
+ /// `tileConsumerAndFuseProducersUsingSCF`, followed by any operations that
+ /// were fused with it.
llvm::SetVector<Operation *> tiledAndFusedOps;
/// The `scf.for` operations that iterate over the tiles.
SmallVector<LoopLikeOpInterface> loops;
|
MaheshRavishankar
approved these changes
Jun 23, 2025
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
…mber of `SCFTileAndFuseResult` (llvm#145397) Comment was a little unclear, hopefully this change is an improvement.
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…mber of `SCFTileAndFuseResult` (llvm#145397) Comment was a little unclear, hopefully this change is an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment was a little unclear, hopefully this change is an improvement.