-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[X86] [clang] Add missing check line for diamondrapids (NFC) #145542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @e-kud @phoebewang for review |
@llvm/pr-subscribers-clang Author: Mikołaj Piróg (mikolaj-pirog) ChangesAs in title. Without it, the test doesn't check for dmr Full diff: https://github.com/llvm/llvm-project/pull/145542.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/attr-target-mv.c b/clang/test/CodeGen/attr-target-mv.c
index 6911b55203b7e..07f47d93cd29c 100644
--- a/clang/test/CodeGen/attr-target-mv.c
+++ b/clang/test/CodeGen/attr-target-mv.c
@@ -201,6 +201,8 @@ void calls_pr50025c(void) { pr50025c(); }
// ITANIUM: ret i32 25
// ITANIUM: define{{.*}} i32 @foo.arch_clearwaterforest()
// ITANIUM: ret i32 26
+// ITANIUM: define{{.*}} i32 @foo.arch_diamondrapids()
+// ITANIUM: ret i32 27
// ITANIUM: define{{.*}} i32 @foo()
// ITANIUM: ret i32 2
// ITANIUM: define{{.*}} i32 @bar()
@@ -258,6 +260,8 @@ void calls_pr50025c(void) { pr50025c(); }
// WINDOWS: ret i32 25
// WINDOWS: define dso_local i32 @foo.arch_clearwaterforest()
// WINDOWS: ret i32 26
+// WINDOWS: define dso_local i32 @foo.arch_diamondrapids()
+// WINDOWS: ret i32 27
// WINDOWS: define dso_local i32 @foo()
// WINDOWS: ret i32 2
// WINDOWS: define dso_local i32 @bar()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/8122 Here is the relevant piece of the build log for the reference
|
…5542) As in title. Without it, the test doesn't check for dmr
As in title. Without it, the test doesn't check for dmr