[Target][KernelInfo] Fix kernel-info remarks missing from YAML optimization records #145603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix provides meaningful source locations by falling back to the containing function's subprogram information instead of showing unknown locations.
miguelcsx
force-pushed
the
refac/kernel-info
branch
from
06bb439 to
131546e
Compare
miguelcsx
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
… for YAML remark output The kernel-info pass was registered using FullLinkTimeOptimizationLastEPCallback, which runs after the optimization record YAML files have been finalized. This caused kernel-info remarks to appear in terminal output but not in YAML files when using -fsave-optimization-record. Move kernel-info registration to OptimizerLastEPCallback, which runs during the LTO optimization pipeline while the remark streamer is still active. This ensures kernel-info remarks (including NVVM GPU intrinsics like @llvm.nvvm.read.ptx.sreg.tid.x) are captured in both terminal output and YAML optimization record files. Affects NVPTX and AMDGPU targets.
miguelcsx
force-pushed
the
refac/kernel-info
branch
from
131546e to
9f77d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where kernel-info pass remarks were not being saved to YAML optimization record files when using
-fsave-optimization-record, despite appearing in terminal output.Problem
The kernel-info pass was registered using
FullLinkTimeOptimizationLastEPCallback, which runs after the LTO pipeline completes and after the remark streamer has been finalized. This timing issue caused:Solution
Move kernel-info pass registration from
FullLinkTimeOptimizationLastEPCallbacktoOptimizerLastEPCallback, which runs during the LTO optimization pipeline while the remark streamer is still active.Resulting Diff in YAML Output
Example of YAML output before and after this change:
Targets Affected
Testing
Tested with: