[lllvm] add Passes to LLVM_LINK_COMPONENTS for LLVMMCATests #145617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
Passes
toLLVM_LINK_COMPONENTS
forLLVMMCATests
so that it links properly when LLVM is built as a Windows DLL.Background
LLVPasses
appears to be a missing dependency fromLLVMMCATests
, but when LLVM is built statically it picks-up the requiredLLVMPasses
symbols from a transitive dependency (presumably). When LLVM is built as a Windows DLL,LLVMMCATests
fails to link 4 symbols fromLLVMPasses
without this change:Validation
Local builds and tests to validate cross-platform compatibility. This included llvm, clang, and lldb on the following configurations: