Skip to content

Delete copy constructor/assignment; NFC #145689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

AaronBallman
Copy link
Collaborator

This is an RAII object and static analysis was flagging it for not following the rule of three (or five).

This is an RAII object and static analysis was flagging it for not
following the rule of three (or five).
@AaronBallman AaronBallman added the clang:codegen IR generation bugs: mangling, exceptions, etc. label Jun 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 25, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-codegen

Author: Aaron Ballman (AaronBallman)

Changes

This is an RAII object and static analysis was flagging it for not following the rule of three (or five).


Full diff: https://github.com/llvm/llvm-project/pull/145689.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/CodeGenFunction.h (+3)
diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h
index 59f14b3e35fd0..6c32c98cec011 100644
--- a/clang/lib/CodeGen/CodeGenFunction.h
+++ b/clang/lib/CodeGen/CodeGenFunction.h
@@ -234,6 +234,9 @@ class ApplyAtomGroup {
   uint64_t OriginalAtom = 0;
   CGDebugInfo *DI = nullptr;
 
+  ApplyAtomGroup(const ApplyAtomGroup &) = delete;
+  void operator=(const ApplyAtomGroup &) = delete;
+
 public:
   ApplyAtomGroup(CGDebugInfo *DI);
   ~ApplyAtomGroup();

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 25, 2025
@AaronBallman AaronBallman requested a review from shafik June 25, 2025 12:28
@AaronBallman AaronBallman merged commit 77618a9 into llvm:main Jun 25, 2025
10 checks passed
@AaronBallman AaronBallman deleted the aballman-sa-atom-group branch June 25, 2025 13:11
anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025
This is an RAII object and static analysis was flagging it for not
following the rule of three (or five).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants