[Offload] Add a stub unloadBinaryImpl for host device

[RossBrunton]

No description provided.

[llvmbot]

@llvm/pr-subscribers-offload

Author: Ross Brunton (RossBrunton)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/145716.diff

1 Files Affected:

• (modified) offload/plugins-nextgen/host/src/rtl.cpp (+8)

diff --git a/offload/plugins-nextgen/host/src/rtl.cpp b/offload/plugins-nextgen/host/src/rtl.cpp
index ced9208acaedc..817a6c6d87d13 100644
--- a/offload/plugins-nextgen/host/src/rtl.cpp
+++ b/offload/plugins-nextgen/host/src/rtl.cpp
@@ -147,6 +147,14 @@ struct GenELF64DeviceTy : public GenericDeviceTy {
   /// Initialize the device, which is a no-op
   Error initImpl(GenericPluginTy &Plugin) override { return Plugin::success(); }
 
+  /// Unload the binary image
+  ///
+  /// TODO: This currently does nothing, and should be implemented as part of
+  /// broader memory handling logic for this plugin
+  Error unloadBinaryImpl(DeviceImageTy *) override {
+    return Plugin::success();
+  }
+
   /// Deinitialize the device, which is a no-op
   Error deinitImpl() override { return Plugin::success(); }
 

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[jhuber6]

You likely want DynamicLibrary::closeLibrary().

[RossBrunton]

Shall I do that as a separate change, and just merge this as is to unbreak the buildbot?

[jhuber6]

Sure, though honestly there's probably a lot that needs to be fixed about this plugin.