[mlir][linalg] Fix module dependency issue due to unused import #145727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified. The include is unused in WinogradConv2D.cpp, so this change removes it.
sabauma
requested review from
dcaballe,
nicolasvasilache and
rengolin
as code owners
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-linalg Author: Spenser Bauman (sabauma) ChangesThis include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified. The include is unused in WinogradConv2D.cpp, so this change removes it. Full diff: https://github.com/llvm/llvm-project/pull/145727.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
index c61b23c63dc56..4e90defebcf5c 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
@@ -15,7 +15,6 @@
#include "mlir/Dialect/Affine/IR/AffineOps.h"
#include "mlir/Dialect/Arith/IR/Arith.h"
#include "mlir/Dialect/Linalg/IR/Linalg.h"
-#include "mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h"
#include "mlir/Dialect/Linalg/Utils/Utils.h"
#include "mlir/Dialect/Tensor/IR/Tensor.h"
#include "mlir/Dialect/Utils/StaticValueUtils.h"
|
itf
approved these changes
Jun 25, 2025
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…#145727) This include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified. The include is unused in WinogradConv2D.cpp, so this change removes it.
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
…#145727) This include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified. The include is unused in WinogradConv2D.cpp, so this change removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified.
The include is unused in WinogradConv2D.cpp, so this change removes it.