[llvm-objcopy] Explain that strip-preserve-atime.test fails with Crowdstrike #145783
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dstrike Related to llvm#82372. Not a fix per se, but an acknowledgment and a workaround.
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Ross Kirsling (rkirsling) ChangesRelated to #82372. Full diff: https://github.com/llvm/llvm-project/pull/145783.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test b/llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
index b145599d9ff33..c08580f32ecfd 100644
--- a/llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
+++ b/llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
@@ -1,6 +1,8 @@
# Note: ls -lu prints the accessed timestamp
# NetBSD: noatime mounts currently inhibit 'touch -a' updates
# Windows: the last access time is disabled by default in the OS
+# This test is also known to fail on Mac (and possibly elsewhere) when Crowdstrike is installed;
+# please make use of the LIT_XFAIL environment variable on such machines.
# UNSUPPORTED: system-netbsd, system-windows
# Preserve dates when stripping to an output file.
|
jh7370
reviewed
Jun 26, 2025
|
It consistently fails on my machine; not sure if @hiraditya had experienced intermittent passes. |
|
(I'd ask for this to be merged, but I figure it'll be a good way to test out my ability to do so myself once my commit access invite arrives.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #82372.
Not a fix per se, but an acknowledgment and a workaround.