-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[NFC] [sanitizer] fix inaccurate comment #145809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] [sanitizer] fix inaccurate comment #145809
Conversation
Created using spr 1.3.4
@llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/145809.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/Sanitizers.h b/clang/include/clang/Basic/Sanitizers.h
index 3782deb5962bc..b299de99157e7 100644
--- a/clang/include/clang/Basic/Sanitizers.h
+++ b/clang/include/clang/Basic/Sanitizers.h
@@ -218,8 +218,8 @@ bool parseSanitizerWeightedValue(StringRef Value, bool AllowGroups,
void serializeSanitizerSet(SanitizerSet Set,
SmallVectorImpl<StringRef> &Values);
-/// Serialize a SanitizerMaskCutoffs into values for -fsanitize= or
-/// -fno-sanitize=.
+/// Serialize a SanitizerMaskCutoffs into values for
+// -fsanitize-skip-hot-cutoff=.
void serializeSanitizerMaskCutoffs(const SanitizerMaskCutoffs &Cutoffs,
SmallVectorImpl<std::string> &Values);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing about this function that is specific to -fsanitize-skip-hot-cutoffs. It's general enough that it could be used for any future -fsanitize- flags that need cutoffs.
So, just remove the "... for fsanitize"? |
Yes. Drop the " for -fsanitize= or /// -fno-sanitize=". Just "Serialize a SanitizerMaskCutoffs into values." It's cleaner. |
No description provided.